Simplify `download_file`. NFC Remove the unused `download_even_if_exists` parameter from `download_file`. The only callsite was `try_download`, which passed `not KEEP_DOWNLOADS` for `download_even_if_exists`. Replacing `not download_even_if_exists` with `KEEP_DOWNLOADS` inside `download_file` preserves exact behavior while simplifying the function signature.
diff --git a/emsdk.py b/emsdk.py index 8d82f3c..ab023d8 100644 --- a/emsdk.py +++ b/emsdk.py
@@ -696,15 +696,14 @@ debug_print('finished downloading (%d bytes)' % file_size_dl) -def download_file(url, dstpath, download_even_if_exists=False, - filename_prefix=''): +def download_file(url, dstpath, filename_prefix=''): """On success, returns the filename on the disk pointing to the destination file that was produced On failure, returns None. """ debug_print(f'download_file(url={url}, dstpath={dstpath})') file_name = get_download_target(url, dstpath, filename_prefix) - if os.path.exists(file_name) and not download_even_if_exists: + if KEEP_DOWNLOADS and os.path.exists(file_name): print(f"File '{file_name}' already downloaded, skipping.") return file_name @@ -1530,7 +1529,7 @@ url = urljoin(emsdk_packages_url, archive) def try_download(url): - return download_file(url, download_dir, not KEEP_DOWNLOADS, filename_prefix) + return download_file(url, download_dir, filename_prefix) # Special hack for the wasm-binaries we transitioned from `.bzip2` to # `.xz`, but we can't tell from the version/url which one to use, so