[bazel] Support .symbols extension in link_wrapper Update link_wrapper.py and wasm_cc_binary.bzl to look for and allow .symbols output extension instead of .js.symbols, matching emcc's output naming scheme for symbol maps. Fixes: #1092
diff --git a/bazel/emscripten_toolchain/link_wrapper.py b/bazel/emscripten_toolchain/link_wrapper.py index f5a923b..4e9a150 100644 --- a/bazel/emscripten_toolchain/link_wrapper.py +++ b/bazel/emscripten_toolchain/link_wrapper.py
@@ -84,7 +84,7 @@ '.wasm', '.wasm.map', '.data', - '.js.symbols', + '.symbols', '.wasm.debug.wasm', '.html', '.ts',
diff --git a/bazel/emscripten_toolchain/wasm_cc_binary.bzl b/bazel/emscripten_toolchain/wasm_cc_binary.bzl index d0f21b1..84bc101 100644 --- a/bazel/emscripten_toolchain/wasm_cc_binary.bzl +++ b/bazel/emscripten_toolchain/wasm_cc_binary.bzl
@@ -61,7 +61,7 @@ ".wasm", ".wasm.map", ".data", - ".js.symbols", + ".symbols", ".wasm.debug.wasm", ".html", ".ts", @@ -186,7 +186,7 @@ "wasm": "{}/{}.wasm".format(name, basename), "map": "{}/{}.wasm.map".format(name, basename), "data": "{}/{}.data".format(name, basename), - "symbols": "{}/{}.js.symbols".format(name, basename), + "symbols": "{}/{}.symbols".format(name, basename), "dwarf": "{}/{}.wasm.debug.wasm".format(name, basename), "html": "{}/{}.html".format(name, basename), }
diff --git a/bazel/test_external/BUILD b/bazel/test_external/BUILD index 6fe7722..b8b7813 100644 --- a/bazel/test_external/BUILD +++ b/bazel/test_external/BUILD
@@ -4,6 +4,7 @@ cc_binary( name = "hello-world", srcs = ["hello-world.cc"], + linkopts = ["--emit-symbol-map"], ) wasm_cc_binary( @@ -12,6 +13,7 @@ outputs = [ "hello-world.js", "hello-world.wasm", + "hello-world.symbols", ], )
diff --git a/test/test_bazel.sh b/test/test_bazel.sh index f4699fe..3ba1c39 100755 --- a/test/test_bazel.sh +++ b/test/test_bazel.sh
@@ -26,6 +26,7 @@ pushd test_external bazel build //:hello-world-wasm +test -f bazel-bin/hello-world.symbols bazel build //long_command_line:long_command_line_wasm bazel build //:hello-embind-wasm --compilation_mode dbg # debug