Hoist CallOnceImpl transition table to inline constexpr kCallOnceTransitions. Defining trans as a function-local static array inside the CallOnceImpl function template caused every distinct Callable and Args template instantiation of absl::call_once to emit its own duplicate 36-byte SpinLockWaitTransition table in .rodata. Moving the table to namespace scope as inline constexpr kCallOnceTransitions deduplicates it into a single shared table across the binary. PiperOrigin-RevId: 1018580889
diff --git a/absl/base/call_once.h b/absl/base/call_once.h index 58d5d23..4c8bdbd 100644 --- a/absl/base/call_once.h +++ b/absl/base/call_once.h
@@ -148,6 +148,11 @@ kOnceDone = 221, // Random Number }; +inline constexpr SpinLockWaitTransition kCallOnceTransitions[] = { + {kOnceInit, kOnceRunning, true}, + {kOnceRunning, kOnceWaiter, false}, + {kOnceDone, kOnceDone, true}}; + template <typename Callable, typename... Args> void CallOnceImpl(std::atomic<uint32_t>* absl_nonnull control, @@ -166,10 +171,6 @@ } } #endif // NDEBUG - static const base_internal::SpinLockWaitTransition trans[] = { - {kOnceInit, kOnceRunning, true}, - {kOnceRunning, kOnceWaiter, false}, - {kOnceDone, kOnceDone, true}}; // Must do this before potentially modifying control word's state. base_internal::SchedulingHelper maybe_disable_scheduling(scheduling_mode); @@ -180,8 +181,9 @@ uint32_t old_control = kOnceInit; if (control->compare_exchange_strong(old_control, kOnceRunning, std::memory_order_relaxed) || - base_internal::SpinLockWait(control, static_cast<int>(std::size(trans)), - trans, scheduling_mode) == kOnceInit) { + base_internal::SpinLockWait( + control, static_cast<int>(std::size(kCallOnceTransitions)), + kCallOnceTransitions, scheduling_mode) == kOnceInit) { std::invoke(std::forward<Callable>(fn), std::forward<Args>(args)...); old_control = control->exchange(base_internal::kOnceDone, std::memory_order_release);