commit e64dd622d7643b838b4f9c594f3d22a5d33bf58c
author Evan Brown <ezb@google.com> Fri Aug 30 10:08:33 2024 -0700
committer Copybara-Service <copybara-worker@google.com> Fri Aug 30 10:09:40 2024 -0700
tree 95cff455cbc69b8ff1c8625a8578f082a2c17d22
parent 1031858eb2b87a5d47f236d8eac11d8b05c535d5

Add moved-from validation for the case of self-move-assignment.

PiperOrigin-RevId: 669363872
Change-Id: I2aeac23eb082a7bdabe65b3f55fd8adea6930386

absl/container/internal/raw_hash_set.h

diff --git a/absl/container/internal/raw_hash_set.h b/absl/container/internal/raw_hash_set.h
index c371832..f5463fb 100644
--- a/absl/container/internal/raw_hash_set.h
+++ b/absl/container/internal/raw_hash_set.h
@@ -3777,7 +3777,7 @@
     // We only enable moved-from validation when generations are enabled (rather
     // than using NDEBUG) to avoid issues in which NDEBUG is enabled in some
     // translation units but not in others.
-    if (SwisstableGenerationsEnabled() && this != &that) {
+    if (SwisstableGenerationsEnabled()) {
       that.common().set_capacity(InvalidCapacity::kMovedFrom);
     }
     if (!SwisstableGenerationsEnabled() || capacity() == DefaultCapacity() ||

absl/container/internal/raw_hash_set_test.cc

diff --git a/absl/container/internal/raw_hash_set_test.cc b/absl/container/internal/raw_hash_set_test.cc
index 3d5f59a..f69fca3 100644
--- a/absl/container/internal/raw_hash_set_test.cc
+++ b/absl/container/internal/raw_hash_set_test.cc
@@ -2091,6 +2091,10 @@
   t.emplace("a", "b");
   EXPECT_EQ(1, t.size());
   t = std::move(*&t);
+  if (SwisstableGenerationsEnabled()) {
+    // NOLINTNEXTLINE(bugprone-use-after-move)
+    EXPECT_DEATH_IF_SUPPORTED(t.contains("a"), "");
+  }
   // As long as we don't crash, it's fine.
 }