Change the default visibility for packages to //visibility:private and then change individual build rules back to their prior visibility. The motivation for this change is making sure future additions are private by default so that new rules are not accidentally public. Some of the rules that are currently public were not meant to be, and the fact that they are marked public does not mean they should be used. As always, the rule is never spell out anything with the word internal (or any synonym for internal). Some of these accidentally public rules will be manually corrected with future changes. PiperOrigin-RevId: 942103703 Change-Id: I3162a618f8df05f6060261626385d8aeb2d31054
diff --git a/absl/strings/BUILD.bazel b/absl/strings/BUILD.bazel index 21479a7..5d4319d 100644 --- a/absl/strings/BUILD.bazel +++ b/absl/strings/BUILD.bazel
@@ -24,7 +24,7 @@ ) package( - default_visibility = ["//visibility:public"], + default_visibility = ["//visibility:private"], features = [ "header_modules", "layering_check", @@ -39,6 +39,7 @@ hdrs = ["string_view.h"], copts = ABSL_DEFAULT_COPTS, linkopts = ABSL_DEFAULT_LINKOPTS, + visibility = ["//visibility:public"], deps = [ "//absl/base:config", "//absl/base:core_headers", @@ -97,6 +98,7 @@ # New code should directly depend on :string_view. "string_view.h", ], + visibility = ["//visibility:public"], deps = [ ":append_and_overwrite", ":charset", @@ -135,6 +137,11 @@ ], copts = ABSL_DEFAULT_COPTS, linkopts = ABSL_DEFAULT_LINKOPTS, + visibility = [ + "//absl:friends", + "//absl/log:__subpackages__", + "//absl/status:__pkg__", + ], deps = [ ":resize_and_overwrite", "//absl/base:config", @@ -150,6 +157,7 @@ hdrs = ["resize_and_overwrite.h"], copts = ABSL_DEFAULT_COPTS, linkopts = ABSL_DEFAULT_LINKOPTS, + visibility = ["//visibility:public"], deps = [ "//absl/base:config", "//absl/base:core_headers", @@ -270,6 +278,7 @@ hdrs = ["has_ostream_operator.h"], copts = ABSL_DEFAULT_COPTS, linkopts = ABSL_DEFAULT_LINKOPTS, + visibility = ["//visibility:public"], deps = [ "//absl/base:config", ], @@ -482,6 +491,7 @@ ], copts = ABSL_DEFAULT_COPTS, linkopts = ABSL_DEFAULT_LINKOPTS, + visibility = ["//visibility:public"], deps = [ ":string_view", "//absl/base:config", @@ -666,6 +676,7 @@ ], copts = ABSL_DEFAULT_COPTS, linkopts = ABSL_DEFAULT_LINKOPTS, + visibility = ["//visibility:public"], deps = [ ":append_and_overwrite", ":cord_internal", @@ -923,6 +934,7 @@ ], copts = ABSL_DEFAULT_COPTS, linkopts = ABSL_DEFAULT_LINKOPTS, + visibility = ["//visibility:public"], deps = [ ":cord", ":cord_internal", @@ -951,6 +963,9 @@ hdrs = ["cordz_test_helpers.h"], copts = ABSL_DEFAULT_COPTS, linkopts = ABSL_DEFAULT_LINKOPTS, + visibility = [ + "//absl/strings:__pkg__", + ], deps = [ ":cord", ":cord_internal", @@ -1365,6 +1380,7 @@ ], copts = ABSL_DEFAULT_COPTS, linkopts = ABSL_DEFAULT_LINKOPTS, + visibility = ["//visibility:public"], deps = [ ":str_format_internal", ":string_view",