Fix use-after-move in val/validate.cpp (#3848)
Fix a use-after-move (potential) bug found by the
"bugprone-use-after-move" clang-tidy check.
This is part of a Chromium-related effort (see
https://crbug.com/1122844).
diff --git a/source/val/validate.cpp b/source/val/validate.cpp
index f964b9b..d6e992b 100644
--- a/source/val/validate.cpp
+++ b/source/val/validate.cpp
@@ -284,9 +284,10 @@
const auto execution_model = inst->GetOperandAs<SpvExecutionModel>(0);
const char* str = reinterpret_cast<const char*>(
inst->words().data() + inst->operand(2).offset);
+ const std::string desc_name(str);
ValidationState_t::EntryPointDescription desc;
- desc.name = str;
+ desc.name = desc_name;
std::vector<uint32_t> interfaces;
for (size_t j = 3; j < inst->operands().size(); ++j)
@@ -303,7 +304,7 @@
check_inst->words().data() + inst->operand(2).offset);
const std::string check_name(check_str);
- if (desc.name == check_name &&
+ if (desc_name == check_name &&
execution_model == check_execution_model) {
return vstate->diag(SPV_ERROR_INVALID_DATA, inst)
<< "2 Entry points cannot share the same name and "
