Resolve -Wtautological-undefined-compare when building with clang Comparing 'this' to 'nullptr' will always evaluate to false. clang and gcc optimize away the check entirely, removing the checks silences the warnings. https://clang.llvm.org/docs/DiagnosticsReference.html#wtautological-undefined-compare
diff --git a/src/D3D12MemAlloc.cpp b/src/D3D12MemAlloc.cpp index fecc28c..4b85b11 100644 --- a/src/D3D12MemAlloc.cpp +++ b/src/D3D12MemAlloc.cpp
@@ -9312,11 +9312,6 @@ void Allocation::ReleaseThis() { - if (this == NULL) - { - return; - } - SAFE_RELEASE(m_Resource); switch (m_PackedData.GetType()) @@ -9461,11 +9456,6 @@ void DefragmentationContext::ReleaseThis() { - if (this == NULL) - { - return; - } - D3D12MA_DELETE(m_Pimpl->GetAllocs(), this); } @@ -9526,11 +9516,6 @@ void Pool::ReleaseThis() { - if (this == NULL) - { - return; - } - D3D12MA_DELETE(m_Pimpl->GetAllocator()->GetAllocs(), this); }