golden/go/expstorage/expstorage_test.go

package expstorage

import (
	"testing"
)

import (
	// Using 'require' which is like using 'assert' but causes tests to fail.
	assert "github.com/stretchr/testify/require"

	"skia.googlesource.com/buildbot.git/go/database"
	"skia.googlesource.com/buildbot.git/go/database/testutil"
	"skia.googlesource.com/buildbot.git/golden/go/db"
	"skia.googlesource.com/buildbot.git/golden/go/types"
)

func TestExpectationStores(t *testing.T) {
	// Test the memory store.
	memStore := NewMemExpectationsStore()
	testExpectationStore(t, memStore)

	// Initialize the DB to use a local SQLite instances.
	vdb := database.NewVersionedDB(&database.DatabaseConfig{
		SQLiteFilePath: "correctness.db",
		MigrationSteps: db.MigrationSteps(),
	})
	sqlStore := NewSQLExpectationStore(vdb)
	testExpectationStore(t, sqlStore)
}

func TestMySQLExpecatationsStore(t *testing.T) {
	// Set up the database and make sure it's at the right version.
	conf := &database.DatabaseConfig{
		MySQLString:    testutil.GetTestMySQLConnStr(t, "root", "correctness"),
		MigrationSteps: db.MigrationSteps(),
	}

	// Lock to serialize DB tests
	lockVdb := testutil.GetMySQlLock(t, conf)
	defer func() {
		testutil.ReleaseMySQLLock(t, lockVdb)
		lockVdb.Close()
	}()

	rootVdb := database.NewVersionedDB(conf)
	rootVdb.Migrate(rootVdb.MaxDBVersion())
	defer func() {
		rootVdb.Migrate(0)
	}()

	conf.MySQLString = testutil.GetTestMySQLConnStr(t, "readwrite", "correctness")
	vdb := database.NewVersionedDB(conf)

	// Test the MySQL backed store
	sqlStore := NewSQLExpectationStore(vdb)
	testExpectationStore(t, sqlStore)

	// Test the caching version of the MySQL store.
	cachingStore := NewCachingExpectationStore(sqlStore)
	testExpectationStore(t, cachingStore)
}

// Test against the expectation store interface.
func testExpectationStore(t *testing.T, store ExpectationsStore) {
	TEST_1, TEST_2 := "test1", "test2"

	// digests
	DIGEST_11, DIGEST_12 := "d11", "d12"
	DIGEST_21, DIGEST_22 := "d21", "d22"

	newExps := NewExpectations(true)
	newExps.AddDigests(map[string]types.TestClassification{
		TEST_1: types.TestClassification{
			DIGEST_11: types.POSITIVE,
			DIGEST_12: types.NEGATIVE,
		},
		TEST_2: types.TestClassification{
			DIGEST_21: types.POSITIVE,
			DIGEST_22: types.NEGATIVE,
		},
	})
	err := store.Put(newExps, "user-0")
	assert.Nil(t, err)

	foundExps, err := store.Get(false)
	assert.Nil(t, err)

	assert.Equal(t, newExps.Tests, foundExps.Tests)
	assert.False(t, &newExps == &foundExps)

	// Get modifiable expectations and change them
	changeExps, err := store.Get(true)
	assert.Nil(t, err)
	assert.False(t, &foundExps == &changeExps)

	changeExps.RemoveDigests([]string{DIGEST_11})
	changeExps.RemoveDigests([]string{DIGEST_11, DIGEST_22})
	err = store.Put(changeExps, "user-1")
	assert.Nil(t, err)

	foundExps, err = store.Get(false)
	assert.Nil(t, err)

	assert.Equal(t, types.TestClassification(map[string]types.Label{DIGEST_12: types.NEGATIVE}), foundExps.Tests[TEST_1])
	assert.Equal(t, types.TestClassification(map[string]types.Label{DIGEST_21: types.POSITIVE}), foundExps.Tests[TEST_2])

	changeExps.RemoveDigests([]string{DIGEST_12})
	err = store.Put(changeExps, "user-3")
	assert.Nil(t, err)

	foundExps, err = store.Get(false)
	assert.Nil(t, err)
	assert.Equal(t, 1, len(foundExps.Tests))
}