fiddlecli - 'Failed to run' fiddles should be retried.
Bug: skia:
Change-Id: Ie8241e45987bb23f66fb3cee72b834d7b27d9c2d
Reviewed-on: https://skia-review.googlesource.com/c/179850
Reviewed-by: Joe Gregorio <jcgregorio@google.com>
Commit-Queue: Joe Gregorio <jcgregorio@google.com>
diff --git a/fiddlek/go/client/client.go b/fiddlek/go/client/client.go
index 5aadb9a..a00cf72 100644
--- a/fiddlek/go/client/client.go
+++ b/fiddlek/go/client/client.go
@@ -52,6 +52,11 @@
time.Sleep(sleep)
return nil, false
}
+ // Occasionally runs will exceed 20s which looks like a security violation,
+ // so this forces them to be re-run.
+ if runResults.RunTimeError != "" {
+ return nil, false
+ }
return &runResults, true
}
diff --git a/fiddlek/go/fiddlecli/main.go b/fiddlek/go/fiddlecli/main.go
index b25d0b7..c1406b1 100644
--- a/fiddlek/go/fiddlecli/main.go
+++ b/fiddlek/go/fiddlecli/main.go
@@ -22,7 +22,7 @@
const (
// VERSION of the application. Update for major and minor changes to functionality.
- VERSION = "1.1"
+ VERSION = "1.2"
)
// flags
