[skcq] Allow tasks.json to be modified by non-committers
It is a common file to modify and only committers are
going to approve the change.
Bug: skia:12053
Change-Id: I18239153798a1f2f8469e85132157324a81ba48e
Reviewed-on: https://skia-review.googlesource.com/c/buildbot/+/431616
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
diff --git a/skcq/go/config/cfg_reader.go b/skcq/go/config/cfg_reader.go
index d8f06fa..fb3b25a 100644
--- a/skcq/go/config/cfg_reader.go
+++ b/skcq/go/config/cfg_reader.go
@@ -113,16 +113,10 @@
// GetTasksCfg implements the ConfigReader interface.
func (gc *GitilesConfigReader) GetTasksCfg(ctx context.Context, tasksJSONPath string) (*specs.TasksCfg, error) {
// If tasks.json is in list of changed files then use that. Else use from HEAD.
- contents, modifiedInCL, err := gc.getFileContents(ctx, tasksJSONPath)
+ contents, _, err := gc.getFileContents(ctx, tasksJSONPath)
if err != nil {
return nil, err
}
- if modifiedInCL && !gc.canModifyCfgsOnTheFly.Member(gc.ci.Owner.Email) {
- return nil, &CannotModifyCfgsOnTheFlyError{
- issueID: gc.ci.Issue,
- issueOwner: gc.ci.Owner.Email,
- }
- }
cfg, err := specs.ParseTasksCfg(contents)
if err != nil {
return nil, skerr.Fmt("Error when parsing tasks.json cfg: %s", err)
