Infra-PerCommit-Build: Include frontend apps that use Docker in their build process.
These apps were previously excluded from the Infra-PerCommit-Build task because it used not to support running Docker containers. This was fixed in https://skia-review.googlesource.com/c/buildbot/+/324707, so we are now able to include said apps.
After this CL lands, all frontend code in this repository should be included in Infra-PerCommit-Build.
Bug: skia:10321
Change-Id: Ic1ecf31dc12d68c8c905c3a58d6239d5cbd0cfcd
Reviewed-on: https://skia-review.googlesource.com/c/buildbot/+/324709
Commit-Queue: Leandro Lovisolo <lovisolo@google.com>
Reviewed-by: Leandro Lovisolo <lovisolo@google.com>
Reviewed-by: Kevin Lubick <kjlubick@google.com>
diff --git a/Makefile b/Makefile
index c4fcf7a..c277ff0 100644
--- a/Makefile
+++ b/Makefile
@@ -87,6 +87,8 @@
/src/puppeteer-tests/docker/run-tests.sh
# Front-end code will be built by the Infra-PerCommit-Build tryjob.
+#
+# All apps with a webpack.config.ts file should be included here.
.PHONY: build-frontend-ci
build-frontend-ci:
# Generate the //puppeteer-tests/node_modules directory. Some targets will not compile without it.
@@ -100,39 +102,26 @@
cd am && $(MAKE) build-frontend-ci
cd ct && $(MAKE) build-frontend-ci
cd debugger-app && $(MAKE) build-frontend-ci
+ cd demos && $(MAKE) build-frontend-ci
cd golden && $(MAKE) build-frontend-ci
cd hashtag && $(MAKE) build-frontend-ci
+ cd jsfiddle && $(MAKE) build-frontend-ci
cd leasing && $(MAKE) build-frontend-ci
cd machine && $(MAKE) build-frontend-ci
cd new_element && $(MAKE) build-frontend-ci
+ cd particles && $(MAKE) build-frontend-ci
cd perf && $(MAKE) build-frontend-ci
cd power && $(MAKE) build-frontend-ci
cd pulld && $(MAKE) build-frontend-ci
cd push && $(MAKE) build-frontend-ci
+ cd skottie && $(MAKE) build-frontend-ci
cd status && $(MAKE) build-frontend-ci
cd task_driver && $(MAKE) build-frontend-ci
cd tree_status && $(MAKE) build-frontend-ci
- # The following apps are commented out because they require running the
- # gcr.io/skia-public/skia-wasm-release:prod Docker container as part of their build process, which
- # currently produces an authorization error when run from the Infra-PerCommit-Build tryjob, e.g.:
- #
- # $ docker run -u $(id -u chrome-bot):$(id -g chrome-bot) --rm \
- # --volume `pwd`/build:/OUT gcr.io/skia-public/skia-wasm-release:prod \
- # sh -c "cp -r /tmp/* /OUT/"
- #
- # Unable to find image 'gcr.io/skia-public/skia-wasm-release:prod' locally
- # docker: Error response from daemon: unauthorized: You don't have the needed permissions to
- # perform this operation, and you may have invalid credentials. To authenticate your request,
- # follow the steps in: https://cloud.google.com/container-registry/docs/advanced-authentication.
- # See 'docker run --help'.
-
- # cd demos && $(MAKE) build-frontend-ci
- # cd jsfiddle && $(MAKE) build-frontend-ci
- # cd particles && $(MAKE) build-frontend-ci
- # cd skottie && $(MAKE) build-frontend-ci
-
# Front-end tests will be included in the Infra-PerCommit-Medium tryjob.
+#
+# All apps with a karma.conf.ts file should be included here.
.PHONY: test-frontend-ci
test-frontend-ci:
# Generate the //puppeteer-tests/node_modules directory. Some targets will not compile without it.
