commit b9f79a8fc5a4b1225d9eb7f2720f32db1561cc8c
author Kevin Lubick <kjlubick@google.com> Mon Oct 19 09:33:54 2020 -0400
committer Skia Commit-Bot <skia-commit-bot@chromium.org> Mon Oct 19 18:39:49 2020 +0000
tree 24fb5030707e9a823c6510a122775240d57a858c
parent 198e2b96b0bf5dde90ed20a0c66d412a048e0e26

[gold] Don't crash if patchsets or tryjobs are empty

I noticed this happened when messing around with slightly faulty data.

Change-Id: I7905ac1ce61300f675244358ad068c024172159e
Reviewed-on: https://skia-review.googlesource.com/c/buildbot/+/328158
Reviewed-by: Leandro Lovisolo <lovisolo@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>

golden/modules/changelist-controls-sk/changelist-controls-sk.ts

diff --git a/golden/modules/changelist-controls-sk/changelist-controls-sk.ts b/golden/modules/changelist-controls-sk/changelist-controls-sk.ts
index aa85791..e31dcbc 100644
--- a/golden/modules/changelist-controls-sk/changelist-controls-sk.ts
+++ b/golden/modules/changelist-controls-sk/changelist-controls-sk.ts
@@ -37,7 +37,7 @@
 
       <div class=inputs>
         <select @input=${ele._onSelectPS}>
-          ${ele._summary!.patch_sets!.map(
+          ${ele._summary.patch_sets?.map(
             (ps) => html`<option ?selected=${ele.ps_order === ps.order}>PS ${ps.order}</option>`)}
         </select>
         <span class=spacer></span>
@@ -58,7 +58,7 @@
       </div>
 
       <div class=tryjob-container>
-        ${ps!.try_jobs!.map((tj) => ChangelistControlsSk.tryJobTemplate(tj))}
+        ${ps?.try_jobs?.map((tj) => ChangelistControlsSk.tryJobTemplate(tj))}
       </div>
     `;
   };