commit 99ee60887e903997d7e15e7415700d644694cea1
author Joe Gregorio <jcgregorio@google.com> Fri Nov 20 20:57:44 2020 -0500
committer Skia Commit-Bot <skia-commit-bot@chromium.org> Sat Nov 21 02:37:20 2020 +0000
tree 6d960ce895a7379b394311333726291097511ad3
parent f58259544cdd7852b94bd780ecdbb649d915a8ca

[perf] Fix crashes from missing shortcutStore.

Change-Id: Icd2aabb3f6152bd579448d26be62e4093f35535f
Reviewed-on: https://skia-review.googlesource.com/c/buildbot/+/337260
Reviewed-by: Joe Gregorio <jcgregorio@google.com>
Commit-Queue: Joe Gregorio <jcgregorio@google.com>

perf/go/regression/continuous/continuous.go

diff --git a/perf/go/regression/continuous/continuous.go b/perf/go/regression/continuous/continuous.go
index 05f091d..320bb42 100644
--- a/perf/go/regression/continuous/continuous.go
+++ b/perf/go/regression/continuous/continuous.go
@@ -93,6 +93,7 @@
 		store:          store,
 		provider:       provider,
 		notifier:       notifier,
+		shortcutStore:  shortcutStore,
 		current:        &Current{},
 		paramsProvider: paramsProvider,
 		dfBuilder:      dfBuilder,

perf/go/regression/detector.go

diff --git a/perf/go/regression/detector.go b/perf/go/regression/detector.go
index a6074c6..4f55be7 100644
--- a/perf/go/regression/detector.go
+++ b/perf/go/regression/detector.go
@@ -109,6 +109,7 @@
 	iter, err := dfiter.NewDataFrameIterator(ctx, nil, dfBuilder, perfGit, nil, req.Query, req.Domain, req.Alert)
 	if err != nil {
 		req.Progress.Error(fmt.Sprintf("Failed to create iterator: %s", err))
+		return
 	}
 	ret := &regressionDetectionProcess{
 		request:                   req,