[Autoroll] Mark manual roll as completed+failed if could not createNewRoll
Similar to when "Already at revision".
Otherwise it will keep trying with no way to stop it except deleting
from firestore.
Bug: skia:10477
Change-Id: Ib8eef7805c310261d494b932a518a73ad2df4227
Reviewed-on: https://skia-review.googlesource.com/c/buildbot/+/303350
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
diff --git a/autoroll/go/roller/autoroller.go b/autoroll/go/roller/autoroller.go
index 80ee88c..b4d592f 100644
--- a/autoroll/go/roller/autoroller.go
+++ b/autoroll/go/roller/autoroller.go
@@ -892,7 +892,14 @@
issue, err = r.createNewRoll(ctx, from, to, emails, req.DryRun)
if err != nil {
- return skerr.Wrapf(err, "Failed to create manual roll for %s: %s", req.Id, err)
+ req.Status = manual.STATUS_COMPLETE
+ req.Result = manual.RESULT_FAILURE
+ req.ResultDetails = fmt.Sprintf("Failed to create manual roll for %s: %s", req.Id, err)
+ sklog.Errorf("Failed to create manual roll: %s", req.ResultDetails)
+ if err := r.manualRollDB.Put(req); err != nil {
+ return skerr.Wrapf(err, "Failed to update manual roll request")
+ }
+ continue
}
} else if req.Status == manual.STATUS_STARTED {
split := strings.Split(req.Url, "/")
