[gold] byblameentry-sk-demo.js: Remove gold-scaffold-sk from demo page.
It gives the false impression that the scaffold is necessary to demo the component, so let's remove it from the demo page.
As an extra benefit, the screenshot taken by the Puppeteer test is now smaller and more focused.
Bug: skia:9525
Change-Id: I424c4321c1bdb680df9525727a33efa65de8d679
Reviewed-on: https://skia-review.googlesource.com/c/buildbot/+/264678
Commit-Queue: Leandro Lovisolo <lovisolo@google.com>
Reviewed-by: Kevin Lubick <kjlubick@google.com>
diff --git a/golden/modules/byblameentry-sk/byblameentry-sk-demo.html b/golden/modules/byblameentry-sk/byblameentry-sk-demo.html
index 874b0a3..f45f1d9 100644
--- a/golden/modules/byblameentry-sk/byblameentry-sk-demo.html
+++ b/golden/modules/byblameentry-sk/byblameentry-sk-demo.html
@@ -7,8 +7,6 @@
<meta name="viewport" content="width=device-width, initial-scale=1.0">
</head>
<body>
-<gold-scaffold-sk app_title="Skia Public" testing_offline>
- <!-- byblameentry-sk elements will be inserted here dynamically. -->
-</gold-scaffold-sk>
+<!-- A byblameentry-sk element will be inserted here dynamically. -->
</body>
</html>
diff --git a/golden/modules/byblameentry-sk/byblameentry-sk-demo.js b/golden/modules/byblameentry-sk/byblameentry-sk-demo.js
index d4ea6a7..9024633 100644
--- a/golden/modules/byblameentry-sk/byblameentry-sk-demo.js
+++ b/golden/modules/byblameentry-sk/byblameentry-sk-demo.js
@@ -1,7 +1,5 @@
-import './index.js'
-import '../gold-scaffold-sk'
-import { $$ } from 'common-sk/modules/dom'
-import { byBlameEntry, fakeNow, gitLog } from './test_data'
+import './index.js';
+import { byBlameEntry, fakeNow, gitLog } from './test_data';
Date.now = () => fakeNow;
@@ -10,4 +8,4 @@
entry.gitLog = gitLog;
entry.baseRepoUrl = 'https://skia.googlesource.com/skia.git';
entry.corpus = 'gm';
-$$('gold-scaffold-sk').appendChild(entry);
+document.body.appendChild(entry);
diff --git a/golden/modules/byblameentry-sk/byblameentry-sk.scss b/golden/modules/byblameentry-sk/byblameentry-sk.scss
index 43eeada..83a1aba 100644
--- a/golden/modules/byblameentry-sk/byblameentry-sk.scss
+++ b/golden/modules/byblameentry-sk/byblameentry-sk.scss
@@ -1,6 +1,8 @@
@import '~elements-sk/colors';
byblameentry-sk {
+ display: block;
+
.blame {
border: 1px solid var(--light-gray);
margin: 10px;
diff --git a/golden/puppeteer-tests/test/byblameentry-sk_puppeteer_test.js b/golden/puppeteer-tests/test/byblameentry-sk_puppeteer_test.js
index 61a17a2..963ab2e 100644
--- a/golden/puppeteer-tests/test/byblameentry-sk_puppeteer_test.js
+++ b/golden/puppeteer-tests/test/byblameentry-sk_puppeteer_test.js
@@ -15,7 +15,8 @@
});
it('should take a screenshot', async function() {
- await this.page.setViewport({ width: 1200, height: 700 });
- await takeScreenshot(this.page, 'byblameentry-sk');
+ await this.page.setViewport({ width: 600, height: 800 });
+ const byBlameEntry = await this.page.$('byblameentry-sk');
+ await takeScreenshot(byBlameEntry, 'byblameentry-sk');
});
});
