| import './index'; |
| |
| import sinon from 'sinon'; |
| import { $$ } from 'common-sk/modules/dom'; |
| import fetchMock from 'fetch-mock'; |
| import { expect } from 'chai'; |
| import { SelectSk } from 'elements-sk/select-sk/select-sk'; |
| import { benchmarks_platforms } from './test_data'; |
| import { pageSets } from '../pageset-selector-sk/test_data'; |
| import { priorities } from '../task-priority-sk/test_data'; |
| import { chromiumPatchResult } from '../patch-sk/test_data'; |
| import { InputSk } from '../input-sk/input-sk'; |
| import { ChromiumPerfSk } from './chromium-perf-sk'; |
| |
| import { |
| eventPromise, |
| setUpElementUnderTest, |
| } from '../../../infra-sk/modules/test_util'; |
| |
| describe('chromium-perf-sk', () => { |
| fetchMock.config.overwriteRoutes = false; |
| const factory = setUpElementUnderTest<ChromiumPerfSk>('chromium-perf-sk'); |
| // Returns a new element with the pagesets, task priorirites, and |
| // active tasks fetches complete, and benchmarks and platforms set. |
| const newInstance = async (activeTasks?: number) => { |
| fetchMock.postOnce('begin:/_/page_sets/', pageSets); |
| fetchMock.postOnce('begin:/_/benchmarks_platforms/', benchmarks_platforms); |
| fetchMock.getOnce('begin:/_/task_priorities/', priorities); |
| mockActiveTasks(activeTasks); |
| const ele = factory(); |
| await fetchMock.flush(true); |
| return ele; |
| }; |
| |
| // Make our test object global to make helper functions convenient. |
| let chromiumPerf: ChromiumPerfSk; |
| |
| afterEach(() => { |
| // Check all mock fetches called at least once and reset. |
| expect(fetchMock.done()).to.be.true; |
| fetchMock.reset(); |
| sinon.restore(); |
| }); |
| |
| const mockActiveTasks = (n: number|undefined) => { |
| n = n || 0; |
| // For running tasks for the user we put a nonzero total in one of the |
| // responses, and 0 in the remaining 6. |
| fetchMock.postOnce('begin:/_/get', { |
| data: [], |
| ids: [], |
| pagination: { offset: 0, size: 1, total: n }, |
| permissions: [], |
| }); |
| fetchMock.post('begin:/_/get', { |
| data: [], |
| ids: [], |
| pagination: { offset: 0, size: 1, total: 0 }, |
| permissions: [], |
| }, { repeat: 6 }); |
| }; |
| |
| const setDescription = (d: string) => { |
| ($$('#description', chromiumPerf) as InputSk).value = d; |
| }; |
| |
| const setBenchmark = (b: string) => { |
| ($$('#benchmark_name', chromiumPerf) as InputSk).value = b; |
| }; |
| |
| const setPatch = async (patchtype: string, value: string, response: any) => { |
| fetchMock.postOnce('begin:/_/cl_data', response); |
| const input = $$(`#${patchtype}_patch input-sk`) as InputSk; |
| input.value = value; |
| input.dispatchEvent(new Event('input', { |
| bubbles: true, |
| })); |
| await fetchMock.flush(true); |
| }; |
| |
| const clickSubmit = () => { |
| ($$('#submit', chromiumPerf) as InputSk).click(); |
| }; |
| |
| const expectTaskTriggered = () => { |
| fetchMock.postOnce('begin:/_/add_chromium_perf_task', {}); |
| }; |
| |
| it('loads, has defaults set', async () => { |
| chromiumPerf = await newInstance(); |
| expect(chromiumPerf._platforms[+($$('#platform_selector', chromiumPerf) as SelectSk) |
| .selection!][0]).to.equal('Linux'); |
| expect($$('#pageset_selector', chromiumPerf)).to.have.property('selected', '10k'); |
| expect($$('#pageset_selector', chromiumPerf)).to.have.property('customPages', ''); |
| expect($$('#repeat_after_days', chromiumPerf)).to.have.property('frequency', '0'); |
| expect($$('#task_priority', chromiumPerf)).to.have.property('priority', '100'); |
| expect($$('#benchmark_args', chromiumPerf)).to.have.property('value', |
| '--output-format=csv --pageset-repeat=1 ' |
| + '--skip-typ-expectations-tags-validation --legacy-json-trace-format'); |
| expect($$('#value_column_name', chromiumPerf)).to.have.property('value', 'avg'); |
| }); |
| |
| it('requires description', async () => { |
| chromiumPerf = await newInstance(); |
| const event = eventPromise('error-sk'); |
| clickSubmit(); |
| const err = await event; |
| expect((err as CustomEvent).detail.message).to.equal('Please specify a description'); |
| }); |
| |
| it('requires benchmark', async () => { |
| chromiumPerf = await newInstance(); |
| setDescription('Testing things'); |
| const event = eventPromise('error-sk'); |
| clickSubmit(); |
| const err = await event; |
| expect((err as CustomEvent).detail.message).to.equal('Please specify a benchmark'); |
| }); |
| |
| it('rejects bad patch', async () => { |
| chromiumPerf = await newInstance(); |
| setDescription('Testing things'); |
| setBenchmark('a benchmark'); |
| await setPatch('skia', '1234', { cl: '1234' }); // Patch result is bogus. |
| let event = eventPromise('error-sk'); |
| clickSubmit(); |
| let err = await event; |
| expect((err as CustomEvent).detail.message).to.contain('Unable to fetch skia patch from CL 1234'); |
| |
| await setPatch('skia', '1234', {}); // CL doesn't load. |
| event = eventPromise('error-sk'); |
| clickSubmit(); |
| err = await event; |
| expect((err as CustomEvent).detail.message).to.contain('Unable to load skia CL 1234'); |
| }); |
| |
| it('triggers a new task', async () => { |
| chromiumPerf = await newInstance(); |
| setDescription('Testing things'); |
| setBenchmark('a benchmark'); |
| await setPatch('chromium', '1234', chromiumPatchResult); |
| chromiumPerf._gotoRunsHistory = () => { |
| // Karma can't handlje page reloads, so disable it. |
| }; |
| expectTaskTriggered(); |
| sinon.stub(window, 'confirm').returns(true); |
| clickSubmit(); |
| await fetchMock.flush(true); |
| const taskJson = JSON.parse(fetchMock.lastOptions()!.body as any); |
| // Here we test the 'interesting' arguments. We try a single patch, |
| // and we don't bother filling in the simple string arguments. |
| const expectation = { |
| benchmark: 'a benchmark', |
| platform: 'Linux', |
| page_sets: '10k', |
| custom_webpages: '', |
| repeat_runs: '1', |
| run_in_parallel: 'False', |
| benchmark_args: '--output-format=csv --pageset-repeat=1 --skip-typ-expectations-tags-validation --legacy-json-trace-format', |
| browser_args_nopatch: '', |
| browser_args_withpatch: '', |
| value_column_name: 'avg', |
| desc: 'Testing https://chromium-review.googlesource.com/c/2222715/3 (Roll Skia from cc7ec24ca824 to 1dbc3b533962 (3 revisions))', |
| chromium_patch: '\n\ndiff --git a/DEPS b/DEPS\nindex 849ae22..ee07579 100644\n--- a/DEPS\n+++ b/DEPS\n@@ -178,7 +178,7 @@\n # Three lines of non-changing comments so that\n # the commit queue can handle CLs rolling Skia\n # and whatever else without interference from each other.\n- \'skia_revision\': \'cc7ec24ca824ca13d5a8a8e562fcec695ae54390\',\n+ \'skia_revision\': \'1dbc3b533962b0ae803a2a5ee89f61146228d73b\',\n # Three lines of non-changing comments so that\n # the commit queue can handle CLs rolling V8\n # and whatever else without interference from each other.\n', |
| skia_patch: '', |
| v8_patch: '', |
| catapult_patch: '', |
| chromium_patch_base_build: '', |
| chromium_hash: '', |
| repeat_after_days: '0', |
| task_priority: '100', |
| run_on_gce: 'false', |
| }; |
| expect(taskJson).to.deep.equal(expectation); |
| }); |
| |
| it('rejects if too many active tasks', async () => { |
| // Report user as having 4 active tasks. |
| chromiumPerf = await newInstance(4); |
| setDescription('Testing things'); |
| setBenchmark('a benchmark'); |
| const event = eventPromise('error-sk'); |
| clickSubmit(); |
| const err = await event; |
| expect((err as CustomEvent).detail.message).to.contain('You have 4 currently running tasks'); |
| }); |
| }); |