commit 4cd8671704dec8419522b1ee4b14dfa71cdaad18
author Joe Gregorio <jcgregorio@google.com> Tue Aug 13 09:39:37 2019 -0400
committer Skia Commit-Bot <skia-commit-bot@chromium.org> Tue Aug 13 13:59:07 2019 +0000
tree 3b2e0c9fdc9a828094e0f58a6383701f1448e47f
parent fc965fc531d07e0ebd9e22ada45898423ed9c5a6

am - Use <dialog> instead of <dialog-sk>.

Change-Id: I10dd6d17de72853008981b4131c68477ac0c4eb5
Reviewed-on: https://skia-review.googlesource.com/c/buildbot/+/234256
Auto-Submit: Joe Gregorio <jcgregorio@google.com>
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>

am/modules/email-chooser-sk/email-chooser-sk.js

diff --git a/am/modules/email-chooser-sk/email-chooser-sk.js b/am/modules/email-chooser-sk/email-chooser-sk.js
index 499176e..0427154 100644
--- a/am/modules/email-chooser-sk/email-chooser-sk.js
+++ b/am/modules/email-chooser-sk/email-chooser-sk.js
@@ -9,10 +9,10 @@
  * </p>
  *
  */
+import dialogPolyfill from 'dialog-polyfill'
 import { html, render } from 'lit-html'
 import { $$ } from 'common-sk/modules/dom'
 
-import 'elements-sk/dialog-sk'
 import 'elements-sk/styles/buttons'
 import 'elements-sk/styles/select'
 
@@ -24,7 +24,7 @@
   }
 }
 
-const template = (ele) => html`<dialog-sk>
+const template = (ele) => html`<dialog>
   <h2>Assign</h2>
   <select size=10 @input=${ele._input}>
     <option value='' selected>(un-assign)</option>
@@ -34,7 +34,7 @@
     <button @click=${ele._dismiss}>Cancel</button>
     <button @click=${ele._confirm}>OK</button>
   </div>
-</dialog-sk>`;
+</dialog>`;
 
 window.customElements.define('email-chooser-sk', class extends HTMLElement {
   constructor() {
@@ -48,7 +48,8 @@
 
   connectedCallback() {
     this._render();
-    this._dialog = $$('dialog-sk');
+    this._dialog = $$('dialog');
+    dialogPolyfill.registerDialog(this._dialog);
   }
 
   /**
@@ -63,7 +64,7 @@
     this._emails = emails;
     this._owner = owner;
     this._render();
-    this._dialog.shown = true;
+    this._dialog.showModal();
     $$('select', this).focus();
     return new Promise((resolve, reject) => {
       this._resolve = resolve;
@@ -76,12 +77,12 @@
   }
 
   _dismiss() {
-    this._dialog.shown = false;
+    this._dialog.close();
     this._reject();
   }
 
   _confirm() {
-    this._dialog.shown = false;
+    this._dialog.close();
     this._resolve(this._selected);
   }
 

am/package.json

diff --git a/am/package.json b/am/package.json
index fdd5452..b825194 100644
--- a/am/package.json
+++ b/am/package.json
@@ -9,11 +9,12 @@
   "author": "",
   "license": "SEE LICENSE IN LICENSE",
   "dependencies": {
-    "@webcomponents/custom-elements": "~1.2.1",
-    "common-sk": "~3.1.0",
-    "elements-sk": "~2.7.0",
+    "@webcomponents/custom-elements": "~1.2.4",
+    "common-sk": "~3.2.4",
+    "dialog-polyfill": "^0.5.0",
+    "elements-sk": "~2.9.4",
     "html-webpack-inject-attributes-plugin": "^1.0.1",
-    "lit-html": "~0.14.0"
+    "lit-html": "~1.1.2"
   },
   "devDependencies": {
     "chai": "~4.2.0",
@@ -22,15 +23,15 @@
     "karma": "~3.1.4",
     "karma-chai": "~0.1.0",
     "karma-chrome-launcher": "~2.2.0",
-    "karma-firefox-launcher": "~1.1.0",
+    "karma-firefox-launcher": "~1.2.0",
     "karma-mocha": "~1.3.0",
     "karma-sinon": "~1.0.5",
     "karma-webpack": "~3.0.5",
     "mocha": "~5.2.0",
-    "pulito": "~4.1.1",
-    "sinon": "~7.2.2",
-    "webpack": "~4.28.1",
-    "webpack-cli": "~3.1.2",
-    "webpack-dev-server": "~3.1.11"
+    "pulito": "~4.2.2",
+    "sinon": "~7.4.1",
+    "webpack": "~4.39.1",
+    "webpack-cli": "~3.3.6",
+    "webpack-dev-server": "~3.8.0"
   }
 }