[gold] Remove unused VCS dep
Bug: skia:10582
Change-Id: Iebc8c2b672adaa8c23cf232021e8fa1c3c7482d4
Reviewed-on: https://skia-review.googlesource.com/c/buildbot/+/375942
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Leandro Lovisolo <lovisolo@google.com>
diff --git a/golden/cmd/gold_frontend/gold_frontend.go b/golden/cmd/gold_frontend/gold_frontend.go
index 8c8cd8e..162dd73 100644
--- a/golden/cmd/gold_frontend/gold_frontend.go
+++ b/golden/cmd/gold_frontend/gold_frontend.go
@@ -252,7 +252,7 @@
mustStartExpectationsCleanupProcess(ctx, fsc, expStore, ixr)
- handlers := mustMakeWebHandlers(sqlDB, expStore, gsClient, ignoreStore, ixr, reviewSystems, searchAPI, statusWatcher, tileSource, tjs, vcs)
+ handlers := mustMakeWebHandlers(sqlDB, expStore, gsClient, ignoreStore, ixr, reviewSystems, searchAPI, statusWatcher, tileSource, tjs)
rootRouter := mustMakeRootRouter(fsc, handlers)
@@ -696,7 +696,7 @@
}
// mustMakeWebHandlers returns a new web.Handlers.
-func mustMakeWebHandlers(db *pgxpool.Pool, expStore expectations.Store, gsClient storage.GCSClient, ignoreStore ignore.Store, ixr *indexer.Indexer, reviewSystems []clstore.ReviewSystem, searchAPI search.SearchAPI, statusWatcher *status.StatusWatcher, tileSource tilesource.TileSource, tjs tjstore.Store, vcs vcsinfo.VCS) *web.Handlers {
+func mustMakeWebHandlers(db *pgxpool.Pool, expStore expectations.Store, gsClient storage.GCSClient, ignoreStore ignore.Store, ixr *indexer.Indexer, reviewSystems []clstore.ReviewSystem, searchAPI search.SearchAPI, statusWatcher *status.StatusWatcher, tileSource tilesource.TileSource, tjs tjstore.Store) *web.Handlers {
handlers, err := web.NewHandlers(web.HandlersConfig{
Baseliner: simple_baseliner.New(expStore),
DB: db,
@@ -709,7 +709,6 @@
StatusWatcher: statusWatcher,
TileSource: tileSource,
TryJobStore: tjs,
- VCS: vcs,
}, web.FullFrontEnd)
if err != nil {
sklog.Fatalf("Failed to initialize web handlers: %s", err)
diff --git a/golden/go/web/web.go b/golden/go/web/web.go
index 45793cd..ac74b12 100644
--- a/golden/go/web/web.go
+++ b/golden/go/web/web.go
@@ -33,7 +33,6 @@
"go.skia.org/infra/go/skerr"
"go.skia.org/infra/go/sklog"
"go.skia.org/infra/go/util"
- "go.skia.org/infra/go/vcsinfo"
"go.skia.org/infra/golden/go/baseline"
"go.skia.org/infra/golden/go/clstore"
"go.skia.org/infra/golden/go/diff"
@@ -100,7 +99,6 @@
StatusWatcher *status.StatusWatcher
TileSource tilesource.TileSource
TryJobStore tjstore.Store
- VCS vcsinfo.VCS
}
// Handlers represents all the handlers (e.g. JSON endpoints) of Gold.
@@ -152,9 +150,6 @@
if conf.TryJobStore == nil {
return nil, skerr.Fmt("TryJobStore cannot be nil")
}
- if conf.VCS == nil {
- return nil, skerr.Fmt("VCS cannot be nil")
- }
}
return &Handlers{
HandlersConfig: conf,
