| commit | 252efe2ab4656d95eea4cc76dc89e19d2c94bc06 | [log] [tgz] |
|---|---|---|
| author | Vidit Chitkara <viditchitkara@google.com> | Fri Aug 30 20:23:03 2024 +0000 |
| committer | SkCQ <skcq-be@skia-corp.google.com.iam.gserviceaccount.com> | Fri Aug 30 20:46:46 2024 +0000 |
| tree | e90abb837d5818ddc4e06ad351ea4d6feb9f2ae3 | |
| parent | a8e2af908b69c2763272c70fa38e7b2849172c68 [diff] |
Make the close functionality consistent with other close buttons Aligned the close (other action) buttons on the bottom right and put a cross icon on the top right for: - Tooltip - Legacy query dialog - Bisect Dialog - Chart (Removed "Remove all" button as the cross icon does the job) - New/Edit Favorite dialog - Algo dialog on the dry run page Note: The "Remove all" button is working behind a flag. It is by default show but if the users want to hide it then add a query param show_remove_all=false. Bug: b/361511141 Change-Id: Ica0e6b353c8c6842fb7b00fc07e6d40a527b415e Reviewed-on: https://skia-review.googlesource.com/c/buildbot/+/895037 Commit-Queue: Vidit Chitkara <viditchitkara@google.com> Reviewed-by: Jeff Yoon <jeffyoon@google.com>
This repo contains infrastructure code for Skia.
The infrastructure code is generally built to run on x86 linux. Running on other platforms may be possible but is not officially supported and success will vary depending on the command.
The main source code repository is a Git repository hosted at https://skia.googlesource.com/buildbot.git. It is possible to check out this repository directly with git clone or via go get.
Using git clone allows you to work in whatever directory you want. You will still need to set GOPATH in order to build some apps (recommended to put this in a cache dir). E.g.:
$ cd ${WORKDIR}
$ git clone https://skia.googlesource.com/buildbot.git
$ export GOPATH=${HOME}/.cache/gopath/$(basename ${WORKDIR})
$ mkdir $GOPATH
$ cd buildbot
Almost all applications are built with Bazel, and bazelisk is the recommended tool to ensure you have the right version of bazel installed:
go install github.com/bazelbuild/bazelisk@latest go install github.com/bazelbuild/buildtools/buildifier@latest go install github.com/kisielk/errcheck@latest go install golang.org/x/tools/cmd/goimports@latest go install github.com/mikefarah/yq/v4@latest go install go.chromium.org/luci/client/cmd/...@latest
export PATH=$PATH:$(go env GOPATH)/bin
sudo apt-get install jq
bazelisk build --config=mayberemote //...
bazelisk test --config=mayberemote //...
To update generated code run the following in any directory:
go generate ./...
Install Cloud SDK.
Use this command to run the presubmit tests:
./run_unittests --small