//Makefile: Use a specific revision of the puppeteer-tests Docker image.
Currently the puppeteer-tests Make target uses the image tagged with "latest", which might lead to unintended screenshot differences in Gold if a developer pushes a new image to GCR during development.
This CL pins the image version to the one that is currently tagged with "latest".
In follow-up CLs, I will update the puppeteer-tests and RBE toolchain container images to use the same versions of Chrome and any other necessary assets. This will hopefully reduce diffs between screenshots produced via Webpack vs. Bazel, which is important to judge the correctness of our Bazel build.
Bug: skia:10614
Change-Id: I0c096a93d6afea519fe2aec25f40632aa0a834af
Reviewed-on: https://skia-review.googlesource.com/c/buildbot/+/393716
Reviewed-by: Leandro Lovisolo <lovisolo@google.com>
Commit-Queue: Leandro Lovisolo <lovisolo@google.com>
diff --git a/Makefile b/Makefile
index 26f1059..2ccedfe 100644
--- a/Makefile
+++ b/Makefile
@@ -78,6 +78,10 @@
buildall:
go build ./...
+# Docker image used to run Puppeteer tests (Webpack build).
+PUPPETEER_TESTS_DOCKER_IMG=gcr.io/skia-public/puppeteer-tests@sha256:5225ceb3e9a3a22c2e2bc9d23c333a2e2d815ee3ee00d32227013a6a697d55e9
+
+# This is invoked from Infra-PerCommit-Puppeteer.
.PHONY: puppeteer-tests
puppeteer-tests:
# Pull the WASM binaries needed by the debugger-app Webpack build.
@@ -86,7 +90,7 @@
docker run --interactive --rm \
--mount type=bind,source=`pwd`,target=/src \
--mount type=bind,source=`pwd`/puppeteer-tests/output,target=/out \
- gcr.io/skia-public/puppeteer-tests:latest \
+ $(PUPPETEER_TESTS_DOCKER_IMG) \
/src/puppeteer-tests/docker/run-tests.sh
# Front-end code will be built by the Infra-PerCommit-Build tryjob.
