Google Git
Sign in
skia / buildbot / 2482ab089e9043e1b7a65a85aa046603011ddb0f
commit2482ab089e9043e1b7a65a85aa046603011ddb0f[log] [tgz]
authorLeandro Lovisolo <lovisolo@google.com>Wed Apr 07 18:41:36 2021 -0400
committerSkia Commit-Bot <skia-commit-bot@chromium.org>Wed Apr 07 23:05:27 2021 +0000
tree48c5d20b976b482b52180bc77bd41c79e8f05961
parent1983734c5962f1253a3ae0d68e408ea75fb6576a [diff]
//Makefile: Use a specific revision of the puppeteer-tests Docker image.

Currently the puppeteer-tests Make target uses the image tagged with "latest", which might lead to unintended screenshot differences in Gold if a developer pushes a new image to GCR during development.

This CL pins the image version to the one that is currently tagged with "latest".

In follow-up CLs, I will update the puppeteer-tests and RBE toolchain container images to use the same versions of Chrome and any other necessary assets. This will hopefully reduce diffs between screenshots produced via Webpack vs. Bazel, which is important to judge the correctness of our Bazel build.

Bug: skia:10614
Change-Id: I0c096a93d6afea519fe2aec25f40632aa0a834af
Reviewed-on: https://skia-review.googlesource.com/c/buildbot/+/393716
Reviewed-by: Leandro Lovisolo <lovisolo@google.com>
Commit-Queue: Leandro Lovisolo <lovisolo@google.com>
1 file changed
tree: 48c5d20b976b482b52180bc77bd41c79e8f05961
  1. am/
  2. android_ingest/
  3. android_stats/
  4. api/
  5. autoroll/
  6. bash/
  7. bazel/
  8. blamer/
  9. bugs-central/
  10. codereview-watcher/
  11. comments/
  12. contestk/
  13. cq_watcher/
  14. ct/
  15. datahopper/
  16. debugger-app/
  17. demos/
  18. docker/
  19. docker_pushes_watcher/
  20. docs/
  21. docsyserver/
  22. dot/
  23. ds/
  24. external/
  25. fiddlek/
  26. firestore/
  27. get_service_account/
  28. git_cookie_authdaemon/
  29. gitsync/
  30. go/
  31. gold-client/
  32. golden/
  33. hashtag/
  34. html-template-minifier/
  35. infra/
  36. infra-sk/
  37. jsdoc/
  38. jsfiddle/
  39. k8s-checker/
  40. kube/
  41. leasing/
  42. licenses/
  43. machine/
  44. make/
  45. modules/
  46. named-fiddles/
  47. new_element/
  48. particles/
  49. perdiff/
  50. perf/
  51. periodic-trigger/
  52. power/
  53. proberk/
  54. promk/
  55. pulld/
  56. puppeteer-tests/
  57. push/
  58. scrap/
  59. scripts/
  60. shaders/
  61. sk/
  62. sk8s/
  63. skbug/
  64. skfe/
  65. skolo/
  66. skottie/
  67. status/
  68. task_driver/
  69. task_scheduler/
  70. tools/
  71. tree_status/
  72. trybot_updater/
  73. velero/
  74. .bazelignore
  75. .bazelrc
  76. .eslintrc.js
  77. .gitattributes
  78. .gitignore
  79. .mocharc.json
  80. BUILD.bazel
  81. build_infra_prod.sh
  82. cipd.ensure
  83. codereview.settings
  84. DATASTORE.md
  85. DEPS
  86. elements-sk-scss.bzl
  87. go.mod
  88. go.sum
  89. go_repositories.bzl
  90. launch.md
  91. LICENSE
  92. Makefile
  93. package-lock.json
  94. package.json
  95. PRESUBMIT.py
  96. PRIVACY_POLICY.md
  97. README.md
  98. run_unittests
  99. run_unittests.go
  100. STYLEGUIDE.md
  101. tools.go
  102. tsconfig.json
  103. whitespace.txt
  104. WORKSPACE
README.md

Skia-Buildbot Repository

This repo contains infrastructure code for Skia.

Getting the Source Code

The main source code repository is a Git repository hosted at https://skia.googlesource.com/buildbot.git. It is possible to check out this repository directly with git clone or via go get.

Using git clone allows you to work in whatever directory you want. You will still need to set GOPATH in order to build some apps (recommended to put this in a cache dir). E.g.:

$ cd ${WORKDIR}
$ git clone https://skia.googlesource.com/buildbot.git
$ export GOPATH=${HOME}/.cache/gopath/$(basename ${WORKDIR})
$ mkdir $GOPATH
$ cd buildbot

Using go get will fetch the repository into your GOPATH directory along with all the Go dependencies. You will need to set GOPATH and GO111MODULE=on. E.g.:

$ export GOPATH=${WORKDIR}
$ export GO111MODULE=on
$ go get -u -t go.skia.org/infra/...
$ cd ${GOPATH}/src/go.skia.org/infra/

Note: go.skia.org is a custom import path and will only work if used like the examples here.

Install Node.js (not as root) and add the bin dir to your path. Optionally run npm install npm -g, as suggested by the npm getting started doc.

Install other dependencies:

$ sudo apt-get install python-django
$ go get -u github.com/kisielk/errcheck \
  golang.org/x/tools/cmd/goimports \
  go.chromium.org/luci/client/cmd/isolate

Build ~everything:

$ make all

Generated Code

Some code is generated using go generate with external binaries. First, install the version of protoc referenced in the asset creation script and ensure it is on your PATH before other versions of protoc.

Install the necessary go packages:

$ go get -u \
  github.com/golang/protobuf/protoc-gen-go \
  golang.org/x/tools/cmd/stringer \
  google.golang.org/grpc \

Get mockery and add it to your PATH.

To generate code run in this directory:

$ go generate ./...

Running unit tests

Install Cloud SDK.

Use this command to run the presubmit tests:

$ ./run_unittests --small