commit 0391c9c7d52c2ef31d43a2d305e39c0e6158ff6c
author Joe Gregorio <jcgregorio@google.com> Mon Aug 12 13:38:40 2019 -0400
committer Joe Gregorio <jcgregorio@google.com> Mon Aug 12 17:40:46 2019 +0000
tree ce76dd0409481734f09be3a3d5faf8776ce493a5
parent 2ca486c78a8fa65c4c7b41376d3aff39f7fca3f5

Perf - Fix alert-page-sk. We never saw diffs.

Bug: skia:9219
Change-Id: I15e10c0fadbbb63160b3a0663cfe3ff30962c8fb
Reviewed-on: https://skia-review.googlesource.com/c/buildbot/+/234056
Reviewed-by: Joe Gregorio <jcgregorio@google.com>

perf/modules/alerts-page-sk/alerts-page-sk.js

diff --git a/perf/modules/alerts-page-sk/alerts-page-sk.js b/perf/modules/alerts-page-sk/alerts-page-sk.js
index 1f10a33..25cf034 100644
--- a/perf/modules/alerts-page-sk/alerts-page-sk.js
+++ b/perf/modules/alerts-page-sk/alerts-page-sk.js
@@ -134,8 +134,7 @@
     const id = +window.location.search.slice(1);
     for (const alert of this._alerts) {
       if (id === alert.id) {
-        this.cfg = alerts[i];
-        this._dialog.showModal();
+        this._startEditing(alerts[i]);
         break;
       }
     }
@@ -145,14 +144,17 @@
   _add() {
     // Load an new Config from the server.
     fetch('/_/alert/new').then(jsonOrThrow).then((json) => {
-      this.cfg = json;
-      // Pop up edit dialog using the new Config.
-      this._dialog.showModal();
+      this._startEditing(json);
     }).catch(errorMessage);
   }
 
   _edit(e) {
-    this.cfg = e.target.__config;
+    this._startEditing(e.target.__config);
+  }
+
+  _startEditing(cfg) {
+    this._orig_cfg = JSON.parse(JSON.stringify(this._cfg));
+    this.cfg = cfg;
     this._dialog.showModal();
   }
 
@@ -196,7 +198,6 @@
     if (this._cfg && !this._cfg.owner) {
       this._cfg.owner = this._email;
     }
-    this._orig_cfg = JSON.parse(JSON.stringify(this._cfg));
     this._render();
   }