commit 8a5b9cb3ff9cd17b021668861c392e25765106ae
author John Stiles <johnstiles@google.com> Wed Nov 22 09:56:03 2023 -0500
committer SkCQ <skcq-be@skia-corp.google.com.iam.gserviceaccount.com> Wed Nov 22 15:09:36 2023 +0000
tree 4a6472628905d151cecea1bb85cfb880b44ebad7
parent 03a3527b342c29094cc5797f35030116b1a60996

Disable [[clang::musttail]] on Android.

This attribute causes an ICE in Clang 18 when building for Android.

Bug: chromium:1504548
Change-Id: I0e5b3f809e1a007afb4f224b315f4dda8e5909de
Reviewed-on: https://skia-review.googlesource.com/c/skcms/+/782437
Reviewed-by: Brian Osman <brianosman@google.com>
Auto-Submit: John Stiles <johnstiles@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>

src/skcms_internals.h

diff --git a/src/skcms_internals.h b/src/skcms_internals.h
index 917cf07..b5b72fe 100644
--- a/src/skcms_internals.h
+++ b/src/skcms_internals.h
@@ -28,10 +28,12 @@
 
     #ifndef SKCMS_MUSTTAIL
         // Sanitizers do not work well with [[clang::musttail]], and corrupt src/dst pointers.
+        // Clang 18 runs into an ICE on Android with [[clang::musttail]]. (crbug.com/1504548)
         // Tail-calls are a fairly new, optional feature in wasm and won't work everywhere.
         #if __has_cpp_attribute(clang::musttail) && !__has_feature(memory_sanitizer) \
                                                  && !__has_feature(address_sanitizer) \
-                                                 && !defined(__EMSCRIPTEN_major__)
+                                                 && !defined(__EMSCRIPTEN_major__) \
+                                                 && !defined(__ANDROID__)
             #define SKCMS_MUSTTAIL [[clang::musttail]]
         #else
             #define SKCMS_MUSTTAIL