commit 529510fe003a3ccbf2d0d76939bf49f88b825177
author Brian Osman <brianosman@google.com> Mon Dec 04 15:39:26 2023 +0000
committer SkCQ <skcq-be@skia-corp.google.com.iam.gserviceaccount.com> Mon Dec 04 15:59:25 2023 +0000
tree 8af888797961ff93e794b7b1199fc9f9e00eb5e0
parent 4dba2348bc3cb863bc37854d93a44d8c31028d5e

Disable musttail on RISC-V

Bug: b/314692534
Change-Id: I280b9a8d09c39129f4814beaed65fde41a62dc87
Reviewed-on: https://skia-review.googlesource.com/c/skcms/+/785718
Commit-Queue: John Stiles <johnstiles@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
Reviewed-by: John Stiles <johnstiles@google.com>

src/skcms_internals.h

diff --git a/src/skcms_internals.h b/src/skcms_internals.h
index ecb16b6..9c0c89c 100644
--- a/src/skcms_internals.h
+++ b/src/skcms_internals.h
@@ -38,12 +38,14 @@
         // - Wasm tail-calls were only introduced in 2023 and aren't a mainstream feature yet.
         // - Clang 18 runs into an ICE on armv7/androideabi with [[clang::musttail]].
         //   (http://crbug.com/1504548)
+        // - Android RISC-V also runs into an ICE (b/314692534)
         // - Windows builds generate incorrect code with [[clang::musttail]] and crash mysteriously.
         //   (http://crbug.com/1505442)
         #if __has_cpp_attribute(clang::musttail) && !__has_feature(memory_sanitizer) \
                                                  && !__has_feature(address_sanitizer) \
                                                  && !defined(__EMSCRIPTEN__) \
                                                  && !defined(__arm__) \
+                                                 && !defined(__riscv) \
                                                  && !defined(_WIN32) && !defined(__SYMBIAN32__)
             #define SKCMS_MUSTTAIL [[clang::musttail]]
         #else