Add a few missing calls to std::exit on error (#395)
Errors were printed but did not stop processing and as a result the
related issues were not caught by CI checks.
Change-Id: I030c7ffe23a4730106a19e212895bef03b6ca456
Signed-off-by: Kevin Petit <kevin.petit@arm.com>
diff --git a/tools/buildHeaders/jsonToSpirv.cpp b/tools/buildHeaders/jsonToSpirv.cpp
index 04f8079..ee396f0 100644
--- a/tools/buildHeaders/jsonToSpirv.cpp
+++ b/tools/buildHeaders/jsonToSpirv.cpp
@@ -528,8 +528,10 @@
for (const auto& printingClass : printingClasses) {
if (printingClass["tag"].asString().size() > 0)
tags.insert(printingClass["tag"].asString()); // just for error checking
- else
+ else {
std::cerr << "Error: each instruction_printing_class requires a non-empty \"tag\"" << std::endl;
+ std::exit(1);
+ }
if (buildingHeaders || printingClass["tag"].asString() != "@exclude") {
InstructionPrintingClasses.push_back({printingClass["tag"].asString(),
printingClass["heading"].asString()});
@@ -545,6 +547,7 @@
if (printingClass.size() == 0) {
std::cerr << "Error: " << inst["opname"].asString()
<< " requires a non-empty printing \"class\" tag" << std::endl;
+ std::exit(1);
}
if (!buildingHeaders && printingClass == "@exclude")
continue;
@@ -552,6 +555,7 @@
std::cerr << "Error: " << inst["opname"].asString()
<< " requires a \"class\" declared as a \"tag\" in \"instruction printing_class\""
<< std::endl;
+ std::exit(1);
}
const auto opcode = inst["opcode"].asUInt();
const std::string name = inst["opname"].asString();
