| commit | d131b3ddc16993bb6c41871939cefbf288d4718e | [log] [tgz] |
|---|---|---|
| author | Sam Lantinga <slouken@libsdl.org> | Mon Dec 16 10:20:03 2019 -0800 |
| committer | Sam Lantinga <slouken@libsdl.org> | Mon Dec 16 10:20:03 2019 -0800 |
| tree | 7c184e76ce6063fbab5b3b9575b8e52493574880 | |
| parent | f403f9cb0f5fb87b2e13d00edf7a2fe7303d207e [diff] |
Fixed bug 4898 - No rumble because of integer overflow in SDL_JoystickRumble meyraud705 On a Dualshock 4 controller using hidapi driver, calling SDL_JoystickRumble with a duration too long (SDL_HAPTIC_INFINITY for example) causes the rumble to stop immediately. This happens because of integer overflow on line 301 of SDL_hidapi_ps4.c (https://hg.libsdl.org/SDL/file/99ecd178999f/src/joystick/hidapi/SDL_hidapi_ps4.c#l301), which sets expiration time in the past.