commit 98db267344b3d634470e6c572b3f96ebbb43f90f
author Sam Lantinga <slouken@libsdl.org> Wed Mar 27 08:17:05 2019 -0700
committer Sam Lantinga <slouken@libsdl.org> Wed Mar 27 08:17:05 2019 -0700
tree 8b86de25ab963becf004e87815372f606afb478a
parent cc94b3330b4addbf5c247d3131dcc3170f5da762

Handle potentially calling SDL_JoystickUpdate() and SDL_JoystickQuit() at the same time.

src/joystick/SDL_joystick.c

diff --git a/src/joystick/SDL_joystick.c b/src/joystick/SDL_joystick.c
index a5b3e63..430934c 100644
--- a/src/joystick/SDL_joystick.c
+++ b/src/joystick/SDL_joystick.c
@@ -699,9 +699,12 @@
     int i;
 
     /* Make sure we're not getting called in the middle of updating joysticks */
-    SDL_assert(!SDL_updating_joystick);
-
     SDL_LockJoysticks();
+    while (SDL_updating_joystick) {
+        SDL_UnlockJoysticks();
+        SDL_Delay(1);
+        SDL_LockJoysticks();
+    }
 
     /* Stop the event polling */
     while (SDL_joysticks) {
@@ -724,8 +727,9 @@
                         SDL_JoystickAllowBackgroundEventsChanged, NULL);
 
     if (SDL_joystick_lock) {
-        SDL_DestroyMutex(SDL_joystick_lock);
+        SDL_mutex *mutex = SDL_joystick_lock;
         SDL_joystick_lock = NULL;
+        SDL_DestroyMutex(mutex);
     }
 
     SDL_GameControllerQuitMappings();