tree e56c3a3e188c150b96e0a2bb1b81dbdbeb6ade85
parent f5d384360a6c883f205dc2da428b0cb82012f07f
author Cameron Gutman <aicommander@gmail.com> 1584737090 -0700
committer Cameron Gutman <aicommander@gmail.com> 1584737090 -0700

Only enumerate HID devices on Windows that have gamepad HID usages

There are a number of poorly behaved HID devices that time out on attempts to
read various strings. Rather than end up on an endless treadmill of blacklisting
broken devices, reduce our risk by only querying devices that are gamepads.
SDL_hidapijoystick.c already checks these same usages, so we shouldn't
exclude any working HID devices (caveat below).

This also makes HidP_GetPreparsedData() and HidP_GetCaps() failure skip
the device entirely, but that seems desired. If a device can't even return basic
top-level collection data properly, we want nothing to do with that broken device.
If we do find devices that work with HIDAPI joystick and fail these calls, we can
add an exception via VID+PID matching.