commit 27dff946d3509ce42586980ce14eb1c7d179b230
author Albert Astals Cid <aacid@kde.org> Thu Sep 04 14:16:11 2025 +0200
committer Albert Astals Cid <aacid@kde.org> Thu Sep 04 14:25:44 2025 +0200
tree 20653a8e74302ac7e9e80dd889a4666d2fdb74ba
parent 53dd41c6db719aa4523d27a62be9edc3d6f6b131

Make style variable a std::string

poppler/GlobalParams.cc

diff --git a/poppler/GlobalParams.cc b/poppler/GlobalParams.cc
index a4116f3..3d989d3 100644
--- a/poppler/GlobalParams.cc
+++ b/poppler/GlobalParams.cc
@@ -995,12 +995,11 @@
                         substituteName.Set((char *)s2);
                         res = FcPatternGetString(set->fonts[i], FC_STYLE, 0, &s2);
                         if (res == FcResultMatch && s2) {
-                            GooString *style = new GooString((char *)s2);
-                            if (style->cmp("Regular") != 0) {
+                            const std::string style = { (char *)s2 };
+                            if (style != "Regular") {
                                 substituteName.append(" ");
                                 substituteName.append(style);
                             }
-                            delete style;
                         }
                     }
                 }