Simplify QSTringToGooString It already assumes latin1, make it explicit
diff --git a/qt5/src/poppler-private.cc b/qt5/src/poppler-private.cc index a954ac7..882ee7f 100644 --- a/qt5/src/poppler-private.cc +++ b/qt5/src/poppler-private.cc
@@ -150,14 +150,7 @@ std::unique_ptr<GooString> QStringToGooString(const QString &s) { - int len = s.length(); - char *cstring = static_cast<char *>(gmallocn(s.length(), sizeof(char))); - for (int i = 0; i < len; ++i) { - cstring[i] = s.at(i).unicode(); - } - std::unique_ptr<GooString> ret = std::make_unique<GooString>(cstring, len); - gfree(cstring); - return ret; + return std::make_unique<GooString>(s.toLatin1().toStdString()); } std::unique_ptr<GooString> QDateTimeToUnicodeGooString(const QDateTime &dt)
diff --git a/qt6/src/poppler-private.cc b/qt6/src/poppler-private.cc index cf4a4ce..91c77c7 100644 --- a/qt6/src/poppler-private.cc +++ b/qt6/src/poppler-private.cc
@@ -150,14 +150,7 @@ std::unique_ptr<GooString> QStringToGooString(const QString &s) { - int len = s.length(); - char *cstring = static_cast<char *>(gmallocn(s.length(), sizeof(char))); - for (int i = 0; i < len; ++i) { - cstring[i] = s.at(i).unicode(); - } - std::unique_ptr<GooString> ret = std::make_unique<GooString>(cstring, len); - gfree(cstring); - return ret; + return std::make_unique<GooString>(s.toLatin1().toStdString()); } std::unique_ptr<GooString> QDateTimeToUnicodeGooString(const QDateTime &dt)