commit 56dc35f28a3f878e57ad7eb2b0ca63f325882f12
author Albert Astals Cid <aacid@kde.org> Thu Feb 28 17:05:43 2019 +0100
committer Albert Astals Cid <aacid@kde.org> Thu Feb 28 17:33:54 2019 +0100
tree 22c1329cf09c728153f112bc39df9db0b91e7072
parent ff77c618d2d71ff7b9e473b5735b027ec9ba55bd

Annot: Remove unneeded copy() calls

poppler/Annot.cc

diff --git a/poppler/Annot.cc b/poppler/Annot.cc
index 0ebde31..bcd7280 100644
--- a/poppler/Annot.cc
+++ b/poppler/Annot.cc
@@ -1224,9 +1224,9 @@
   }
 
   // Note: This value is overwritten by Annots ctor
-  obj1 = dict->lookupNF("P").copy();
-  if (obj1.isRef()) {
-    Ref ref = obj1.getRef();
+  const Object &pObj = dict->lookupNF("P");
+  if (pObj.isRef()) {
+    Ref ref = pObj.getRef();
 
     page = doc->getCatalog()->findPage (ref.num, ref.gen);
   } else {
@@ -1928,9 +1928,9 @@
     date.reset(obj1.getString()->copy());
   }
 
-  obj1 = dict->lookupNF("IRT").copy();
-  if (obj1.isRef()) {
-    inReplyTo = obj1.getRef();
+  const Object &irtObj = dict->lookupNF("IRT");
+  if (irtObj.isRef()) {
+    inReplyTo = irtObj.getRef();
   } else {
     inReplyTo.num = 0;
     inReplyTo.gen = 0;