)]}' { "commit": "a454242c39341d8866fb76dad426318b1b01296e", "tree": "9ebc2a4c88996e9c1e6bd1925a71f0391fccada1", "parents": [ "eb27c53d935ab0e1a688f999897839708718fac7" ], "author": { "name": "Thomas Smith", "email": "thomsmit@google.com", "time": "Fri Oct 03 10:30:15 2025 -0400" }, "committer": { "name": "SkCQ", "email": "skcq-be@skia-corp.google.com.iam.gserviceaccount.com", "time": "Fri Oct 03 09:29:54 2025 -0700" }, "message": "Reland \"Reland \"[graphite] Extracts early in drawGeometry\"\"\n\nThis reverts commit 5aafacb1358d9dbc00f6b30a056e016e0091aa04.\n\nOriginal change\u0027s description:\n\u003e Revert \"Reland \"[graphite] Extracts early in drawGeometry\"\"\n\u003e\n\u003e This reverts commit 81de4113e3e7cfe8ec91413fbbe51101dcb354e3.\n\u003e\n\u003e Reason for revert: Now breaking chromium roll.\n\u003e\n\u003e Original change\u0027s description:\n\u003e \u003e Reland \"[graphite] Extracts early in drawGeometry\"\n\u003e \u003e\n\u003e \u003e * Reintroduce notify image in use and flush in snapDrawTask.\n\u003e \u003e\n\u003e \u003e * Fixes an issue where multi-draw dependencies were not correctly tracked.\n\u003e \u003e\n\u003e \u003e This reverts commit 1b271fd02a65ba97e12bcaa32f67afa50b5d9b52.\n\u003e \u003e\n\u003e \u003e\n\u003e \u003e Original change\u0027s description:\n\u003e \u003e \u003e Revert \"[graphite] Extracts early in drawGeometry\"\n\u003e \u003e \u003e\n\u003e \u003e \u003e This reverts commit 25f00cb247f23b4a8cbe7a1245bdf609fa0be846.\n\u003e \u003e \u003e\n\u003e \u003e \u003e Reason for revert: Breaks android roll\n\u003e \u003e \u003e\n\u003e \u003e \u003e Original change\u0027s description:\n\u003e \u003e \u003e \u003e [graphite] Extracts early in drawGeometry\n\u003e \u003e \u003e \u003e\n\u003e \u003e \u003e \u003e * Moves the creation of UniquePaintIDs from DrawPass::Snap to PaintParams::toKey, which is called in Device::drawGeometry\n\u003e \u003e \u003e \u003e\n\u003e \u003e \u003e \u003e * Moves blend mode calculations into PaintParams, and adds an enum DstUsage to DrawTypes.\n\u003e \u003e \u003e \u003e\n\u003e \u003e \u003e \u003e * Moves the creation of a draw pass from DrawPass::Make to DrawList::snapDrawPass.\n\u003e \u003e \u003e \u003e\n\u003e \u003e \u003e \u003e * Texture and uniform trackers commensurately moved to DrawList.\n\u003e \u003e \u003e \u003e\n\u003e \u003e \u003e \u003e Change-Id: Ie843db44bfad0cd51773ffa7e42050fdbd7c22e3\n\u003e \u003e \u003e \u003e Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1045336\n\u003e \u003e \u003e \u003e Commit-Queue: Thomas Smith \u003cthomsmit@google.com\u003e\n\u003e \u003e \u003e \u003e Reviewed-by: Michael Ludwig \u003cmichaelludwig@google.com\u003e\n\u003e \u003e \u003e\n\u003e \u003e \u003e No-Presubmit: true\n\u003e \u003e \u003e No-Tree-Checks: true\n\u003e \u003e \u003e No-Try: true\n\u003e \u003e \u003e Change-Id: I19ad73d77051295e37ac9adaae77f228e4934834\n\u003e \u003e \u003e Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1052396\n\u003e \u003e \u003e Commit-Queue: Thomas Smith \u003cthomsmit@google.com\u003e\n\u003e \u003e \u003e Bot-Commit: Rubber Stamper \u003crubber-stamper@appspot.gserviceaccount.com\u003e\n\u003e \u003e\n\u003e \u003e Change-Id: Ib8b9aa5b3ed998bdecd3b56a03ca13f189518178\n\u003e \u003e Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1052657\n\u003e \u003e Reviewed-by: Michael Ludwig \u003cmichaelludwig@google.com\u003e\n\u003e \u003e Commit-Queue: Thomas Smith \u003cthomsmit@google.com\u003e\n\u003e\n\u003e No-Presubmit: true\n\u003e No-Tree-Checks: true\n\u003e No-Try: true\n\u003e Change-Id: I0132ab1e71955f6a8b35b3107afe9ae48f5654aa\n\u003e Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1059636\n\u003e Bot-Commit: Rubber Stamper \u003crubber-stamper@appspot.gserviceaccount.com\u003e\n\u003e Commit-Queue: Thomas Smith \u003cthomsmit@google.com\u003e\n\nChange-Id: I945aeeb179ca3d8ac1fcab857cdd8e641ba25c7a\nReviewed-on: https://skia-review.googlesource.com/c/skia/+/1059899\nCommit-Queue: Thomas Smith \u003cthomsmit@google.com\u003e\nReviewed-by: Michael Ludwig \u003cmichaelludwig@google.com\u003e\n", "tree_diff": [ { "type": "modify", "old_id": "81d300661c75e7ee28a5d257b8a64a86742ba18f", "old_mode": 33188, "old_path": "fuzz/FuzzPrecompile.cpp", "new_id": "db5a758c6b27ffd31e61315e0efb393f7ae0ff99", "new_mode": 33188, "new_path": "fuzz/FuzzPrecompile.cpp" }, { "type": "modify", "old_id": "0046acf78aec509ee61d443aaca6dcd8f6443c6e", "old_mode": 33188, "old_path": "src/gpu/graphite/Device.cpp", "new_id": "875d4fa34d134077e977d4a8e2d3882210a32a7a", "new_mode": 33188, "new_path": "src/gpu/graphite/Device.cpp" }, { "type": "modify", "old_id": "ca7451facfab19fb0e66ad21d7f37174b4e5c50f", "old_mode": 33188, "old_path": "src/gpu/graphite/Device.h", "new_id": "2919523fe80b4e29df9eabbde33973a559e876af", "new_mode": 33188, "new_path": "src/gpu/graphite/Device.h" }, { "type": "modify", "old_id": "fb7a2953e9a6cbb9df9c57dbd53783deebbcff0e", "old_mode": 33188, "old_path": "src/gpu/graphite/DrawContext.cpp", "new_id": "ae4443f8ed42fe8252f1ba0b1c93e9119601fb9b", "new_mode": 33188, "new_path": "src/gpu/graphite/DrawContext.cpp" }, { "type": "modify", "old_id": "9b68fd5b295fab3daeff9b58260154fddb4d82fc", "old_mode": 33188, "old_path": "src/gpu/graphite/DrawContext.h", "new_id": "75dd1ed5937b8a3ba9f7a9659b6b8e8f77bbd092", "new_mode": 33188, "new_path": "src/gpu/graphite/DrawContext.h" }, { "type": "modify", "old_id": "1d24a9b0a16eb2ff8f65a0db5d9595fb2f3a72fb", "old_mode": 33188, "old_path": "src/gpu/graphite/DrawList.cpp", "new_id": "365e747d088806ec1a09d3303e8cce496c5a0a9e", "new_mode": 33188, "new_path": "src/gpu/graphite/DrawList.cpp" }, { "type": "modify", "old_id": "c704bc77f542ef437eb9bacc7041d25e2db2fc74", "old_mode": 33188, "old_path": "src/gpu/graphite/DrawList.h", "new_id": "e5247dfafdddab97a33011a6e5fa0041c9091561", "new_mode": 33188, "new_path": "src/gpu/graphite/DrawList.h" }, { "type": "modify", "old_id": "403a5d4cb1293a4f00f5cc4fb5bf2c2b95d1f249", "old_mode": 33188, "old_path": "src/gpu/graphite/DrawPass.cpp", "new_id": "254cfb6c4da0400b124eeb9a7668e157e7495dcb", "new_mode": 33188, "new_path": "src/gpu/graphite/DrawPass.cpp" }, { "type": "modify", "old_id": "8738756b58cdff29674015b7ac886f753df96ced", "old_mode": 33188, "old_path": "src/gpu/graphite/DrawPass.h", "new_id": "71fa368f11e04013fb590937f0608b3b55b826b8", "new_mode": 33188, "new_path": "src/gpu/graphite/DrawPass.h" }, { "type": "modify", "old_id": "3da8167b5ad428bb0bd19aee9fc7ad971a38f852", "old_mode": 33188, "old_path": "src/gpu/graphite/DrawTypes.h", "new_id": "972f6af8677882b7038bcdfd1e48b9b6f6ce2d51", "new_mode": 33188, "new_path": "src/gpu/graphite/DrawTypes.h" }, { "type": "modify", "old_id": "f35680b08204412cdf9f88d41bc80e8b4c5188a4", "old_mode": 33188, "old_path": "src/gpu/graphite/DrawWriter.cpp", "new_id": "753bd63d2803428d4d2435aa5322b4a22598be74", "new_mode": 33188, "new_path": "src/gpu/graphite/DrawWriter.cpp" }, { "type": "modify", "old_id": "94757825ef54d4dfbd4518fdda9a93478dd75ba2", "old_mode": 33188, "old_path": "src/gpu/graphite/DrawWriter.h", "new_id": "213eeb204cca7f98ace02091091b6cdd2f6a8145", "new_mode": 33188, "new_path": "src/gpu/graphite/DrawWriter.h" }, { "type": "modify", "old_id": "d6cb80f2cd79e5832c95ee7f81d65547dd2432a7", "old_mode": 33188, "old_path": "src/gpu/graphite/KeyContext.cpp", "new_id": "83fe12c89ec92a279e177f3fbf109522e270aff3", "new_mode": 33188, "new_path": "src/gpu/graphite/KeyContext.cpp" }, { "type": "modify", "old_id": "6bb76e940bf6da1889e6921d5a2f846de56b5c68", "old_mode": 33188, "old_path": "src/gpu/graphite/KeyContext.h", "new_id": "9b6126e1d2a90492e0aee07910160dce2d770e71", "new_mode": 33188, "new_path": "src/gpu/graphite/KeyContext.h" }, { "type": "modify", "old_id": "ebc02aa20e434769b4fe69aad1fe851c2f469ea3", "old_mode": 33188, "old_path": "src/gpu/graphite/KeyHelpers.cpp", "new_id": "b4a4e5ee604b6965456b008cb72503bc30dc60ce", "new_mode": 33188, "new_path": "src/gpu/graphite/KeyHelpers.cpp" }, { "type": "modify", "old_id": "154e6d518e407ccfb1c8ee481b951a2541d92ad5", "old_mode": 33188, "old_path": "src/gpu/graphite/KeyHelpers.h", "new_id": "128130330744a9c557eea872d8ac21b9952a7bef", "new_mode": 33188, "new_path": "src/gpu/graphite/KeyHelpers.h" }, { "type": "modify", "old_id": "4c73fc4fd296f8bf16a986d66c1d0e433da34a2a", "old_mode": 33188, "old_path": "src/gpu/graphite/PaintParams.cpp", "new_id": "d137d9bb00bfb8012073ab30e9b79d388f34047d", "new_mode": 33188, "new_path": "src/gpu/graphite/PaintParams.cpp" }, { "type": "modify", "old_id": "9983d9d249e92e8b560699b238be98b38e4c8346", "old_mode": 33188, "old_path": "src/gpu/graphite/PaintParams.h", "new_id": "f958428897f127105cd759523a47eed50cc4954b", "new_mode": 33188, "new_path": "src/gpu/graphite/PaintParams.h" }, { "type": "modify", "old_id": "55e7dd34beed52bbb0b991169ee4acbf9442aba5", "old_mode": 33188, "old_path": "src/gpu/graphite/PipelineData.h", "new_id": "d8083fe38deeaf3234d819bd1805e76b801a4d5b", "new_mode": 33188, "new_path": "src/gpu/graphite/PipelineData.h" }, { "type": "modify", "old_id": "afbbf07011ff318a19ec8caf15b329f567633ec3", "old_mode": 33188, "old_path": "src/gpu/graphite/compute/VelloRenderer.cpp", "new_id": "d8137f7d7011a8f053d1b067c763a5ba7a37d511", "new_mode": 33188, "new_path": "src/gpu/graphite/compute/VelloRenderer.cpp" }, { "type": "modify", "old_id": "5d239aed301c7cacb2dca1876f4ffd2c8e80d693", "old_mode": 33188, "old_path": "tests/graphite/VerticesPaddingTest.cpp", "new_id": "87f31070713aa7a26d320f675deedafc26a41d3c", "new_mode": 33188, "new_path": "tests/graphite/VerticesPaddingTest.cpp" }, { "type": "modify", "old_id": "850db7376fcd35e5b45316f9a4ef9cb79bc2c5b6", "old_mode": 33188, "old_path": "tests/graphite/precompile/PaintParamsKeyTest.cpp", "new_id": "a356ee2712b4b0f97658757c63305d922e391294", "new_mode": 33188, "new_path": "tests/graphite/precompile/PaintParamsKeyTest.cpp" } ] }