tree 26a16df2649a067fda5b237704bf578ef6812dd2
parent 6dbeac51b44b5c4237a552d43e1c37902d6f98c9
author John Stiles <johnstiles@google.com> 1610561366 -0500
committer Skia Commit-Bot <skia-commit-bot@chromium.org> 1610567114 +0000

Allow type-fluid GLSL-style vec2(int, bool) ctors in SkSL.

Note that GLSL accepts these sorts of constructors natively, but Metal
and SPIR-V do not. In the generated IR we actually add a cast for
subexpressions where the type does not match. These casts can be seen in
the final output for both GLSL (where they are no-ops) and Metal/SPIR-V
(where they are essential).

This change exposed some missing SPIR-V functionality (vector casts do
not support bool types). This can be fixed up in a followup CL; these
casts were previously disallowed by SkSL entirely, so there won't be any
of them in existing code.

Change-Id: I54ae922e91b38bed032537496428747a081dc774
Bug: skia:11164, skia:11171
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/353576
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: John Stiles <johnstiles@google.com>
Auto-Submit: John Stiles <johnstiles@google.com>