tree da181d1b822709cb2177a35a2bb521e17d6e9850
parent 5c4c61eeb38fbad721e42ec68f486514a2450418
author Brian Osman <brianosman@google.com> 1585165147 -0400
committer Skia Commit-Bot <skia-commit-bot@chromium.org> 1585167476 +0000

SPIRV: Track function signatures by SpvId(s), rather than display name

It's possible for two types that look distinct (float4 vs half4) to
resolve to the same type ID in the SPIRV. If two function signatures
differ only in that way ("half4 foo(half4)" vs. "half4 bar(float4)"),
we'd end up generating two identical function type declarations, which
is a validation error.

Instead, key the declarations that we've already emitted by resolved
SPIRV Id, so we notice that those functions can share a single type
declaration.

Change-Id: Iea27101612f8990b3750424ca265ba04306f1f25
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/279217
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>