tree 15917b23c3f09f4edd7e5f64225d4e03cda3c0f7
parent fa9232ccfdd54337c595102a908f68db506a1924
author Mike Klein <mtklein@google.com> 1575564358 -0600
committer Skia Commit-Bot <skia-commit-bot@chromium.org> 1575567363 +0000

GCC 8 reminds us, don't memcpy() sk_sp

    ../../include/private/SkTArray.h:496:15:
    error: ‘void* memcpy(void*, const void*, size_t)’ writing to an object of type
    ‘class sk_sp<GrTextBlob>’ with no trivial copy-assignment; use copy-assignment
    or copy-initialization instead [-Werror=class-memaccess]
             memcpy(&fItemArray[dst], &fItemArray[src], sizeof(T));
             ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

This may be safe in context and the sort of thing we're used to getting
away with, but I think it's probably also the sort of thing we should
try to do as little as possible.

If this is really a major performance choke point, it might make sense
to going back to an array of raw pointers?  That's what we had back
before https://skia-review.googlesource.com/c/skia/+/9535/.

Change-Id: If16918f908e8950b81e73b70764bae200bda2e62
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/258265
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>