Update compiler warning flags
- add -Wsign-compare, which has been catching useful issues for Kimmo;
- add -Winit-self and -Wpointer-arith to Mac builds so everyone's using
the same flags;
- try try removing -Wno-uninitialized. This was only for the old 10.6
compiler that we have warnings set as non-errors now.
BUG=skia:
Review URL: https://codereview.chromium.org/872793002
diff --git a/gyp/common_conditions.gypi b/gyp/common_conditions.gypi
index 0fbeb09..394cc6c 100644
--- a/gyp/common_conditions.gypi
+++ b/gyp/common_conditions.gypi
@@ -214,6 +214,7 @@
'-Wextra',
'-Winit-self',
'-Wpointer-arith',
+ '-Wsign-compare',
'-Wno-c++11-extensions',
'-Wno-unused-parameter',
@@ -376,6 +377,7 @@
'-Wextra',
'-Winit-self',
'-Wpointer-arith',
+ '-Wsign-compare',
],
'cflags_cc!': [
'-fno-rtti',
@@ -528,8 +530,11 @@
'WARNING_CFLAGS': [
'-Wall',
'-Wextra',
+ '-Winit-self',
+ '-Wpointer-arith',
+ '-Wsign-compare',
+
'-Wno-unused-parameter',
- '-Wno-uninitialized', # Disabled because we think GCC 4.2 is bad at this.
],
},
},
