tree 470bc3332746cd83dd2f246072f4ac38068379ea
parent 4636ac68de12de22eeb4799478d8cf3d14d77abc
author John Stiles <johnstiles@google.com> 1614611288 -0500
committer Skia Commit-Bot <skia-commit-bot@chromium.org> 1614629210 +0000

Fix fuzzer-discovered error with inlining.

In http://review.skia.org/375776, an optimization was added to the
Inliner, causing it to skip generation of unnecessary temporary
variables. The fuzzer immediately discovered a flaw in this logic: the
"unnecessary" variable was actually used in the rare case that a
function failed to actually return a value. The inliner didn't detect
this case. Of course, this isn't a valid program either, so now we
report the error and cleanly fail.

Change-Id: I1f201cfd33f45cace3be93765a4e214e43a46e69
Bug: oss-fuzz:31469, oss-fuzz:31525
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/377101
Reviewed-by: Ethan Nicholas <ethannicholas@google.com>
Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
Auto-Submit: John Stiles <johnstiles@google.com>