)]}' { "commit": "95101a60c3221f5ebe91b1824e0d5b6050886f46", "tree": "9dd1fe5bb560f4b8085abcd79502ba18e305aedf", "parents": [ "0f29cf4831f3353ec5da4b9dda30240f63c040c5" ], "author": { "name": "John Stiles", "email": "johnstiles@google.com", "time": "Wed Sep 21 17:19:07 2022 -0400" }, "committer": { "name": "SkCQ", "email": "skcq-be@skia-corp.google.com.iam.gserviceaccount.com", "time": "Thu Sep 22 20:56:06 2022 +0000" }, "message": "Allow op-assigned local variables to be eliminated.\n\nI realized that we were over-protective of expressions like `a +\u003d b`\nbecause the `a` was being marked as read-write, but in practice, the\nexpression\u0027s result was being discarded. That is, we were writing,\nbut we weren\u0027t actually reading. An ExpressionStatement will now\nlook for assignment expressions like this one, and demote the\nassignment variable from \"read-write\" to \"write.\" This gives us\nexciting new opportunities for dead local-variable elimination.\n\nChange-Id: I841d001128f0a18e6670a81ff9915aa5a2e44ee0\nReviewed-on: https://skia-review.googlesource.com/c/skia/+/582822\nReviewed-by: Michael Ludwig \u003cmichaelludwig@google.com\u003e\nAuto-Submit: John Stiles \u003cjohnstiles@google.com\u003e\nCommit-Queue: John Stiles \u003cjohnstiles@google.com\u003e\n", "tree_diff": [ { "type": "modify", "old_id": "0acb174b92e20720747f4ddcda44e874b2980c64", "old_mode": 33188, "old_path": "resources/sksl/inliner/TrivialArgumentsInlineDirectly.sksl", "new_id": "46df666dc6f93e22d31df8ba768194a5cad83388", "new_mode": 33188, "new_path": "resources/sksl/inliner/TrivialArgumentsInlineDirectly.sksl" }, { "type": "modify", "old_id": "8aa7dc50fda72321e8d5bcbb552aa85f2cf3d728", "old_mode": 33188, "old_path": "resources/sksl/shared/Assignment.sksl", "new_id": "21ab4bd16af4fe022737af13019ec92903c3f895", "new_mode": 33188, "new_path": "resources/sksl/shared/Assignment.sksl" }, { "type": "modify", "old_id": "1ca32ab27226db6a65c25b3cac96ba96c3867719", "old_mode": 33188, "old_path": "src/sksl/generated/sksl_gpu.dehydrated.sksl", "new_id": "edf672ccba272828b8926a5fa5ae28905af000e3", "new_mode": 33188, "new_path": "src/sksl/generated/sksl_gpu.dehydrated.sksl" }, { "type": "modify", "old_id": "4c0255a4aaf606e4b9f3277563861112ae2917cc", "old_mode": 33188, "old_path": "src/sksl/generated/sksl_graphite_frag.dehydrated.sksl", "new_id": "398c341609942bbbcf9687dce27e21c7fe13a2b8", "new_mode": 33188, "new_path": "src/sksl/generated/sksl_graphite_frag.dehydrated.sksl" }, { "type": "modify", "old_id": "1353119811354e17c509908e2d534760fef96fcc", "old_mode": 33188, "old_path": "src/sksl/generated/sksl_graphite_vert.dehydrated.sksl", "new_id": "326e86aeee9467141eefcd67036f1c3a4be76765", "new_mode": 33188, "new_path": "src/sksl/generated/sksl_graphite_vert.dehydrated.sksl" }, { "type": "modify", "old_id": "e5dbd5ca9c29dafefc9983b18d5ad151b4eb6959", "old_mode": 33188, "old_path": "src/sksl/ir/SkSLExpressionStatement.cpp", "new_id": "7f2831644f71682bf935c2b85735beddffd3c4aa", "new_mode": 33188, "new_path": "src/sksl/ir/SkSLExpressionStatement.cpp" }, { "type": "modify", "old_id": "3bf2b36cda42087e3829637afbcb3b1b9be408b2", "old_mode": 33188, "old_path": "tests/SkSLTest.cpp", "new_id": "2f4b65e7b573b26829074eb4e9828a27a37ed7cc", "new_mode": 33188, "new_path": "tests/SkSLTest.cpp" }, { "type": "modify", "old_id": "8777f076e2a007048befce11c1eb56e4c0daa3ee", "old_mode": 33188, "old_path": "tests/sksl/inliner/TrivialArgumentsInlineDirectly.glsl", "new_id": "cd277f2b889b39be3f77cba5af419cb71ab0ab8c", "new_mode": 33188, "new_path": "tests/sksl/inliner/TrivialArgumentsInlineDirectly.glsl" }, { "type": "modify", "old_id": "6ccbb63e6dbb9de32dcc221d5bd5ee20594e1632", "old_mode": 33188, "old_path": "tests/sksl/shared/Assignment.asm.frag", "new_id": "4afc9c707f8768c2b319bae5a12afe309bab80b0", "new_mode": 33188, "new_path": "tests/sksl/shared/Assignment.asm.frag" }, { "type": "modify", "old_id": "d9cbe52e4dcd5227dbb978fcf98f5cf092837327", "old_mode": 33188, "old_path": "tests/sksl/shared/Assignment.glsl", "new_id": "6b59aae7dae520037a11ac1cbff7c87cab0b3bdc", "new_mode": 33188, "new_path": "tests/sksl/shared/Assignment.glsl" }, { "type": "modify", "old_id": "32e19e141025a07ac0bd19f937a88b1f89f57699", "old_mode": 33188, "old_path": "tests/sksl/shared/Assignment.metal", "new_id": "736cb862e7fce2c9d453385f0573423153cedb3c", "new_mode": 33188, "new_path": "tests/sksl/shared/Assignment.metal" } ] }