tree 708abaa81ecd5e7d253b8cfc4508434a52e49537
parent b2e4416a6bfcec9f773d1ab25df1ef2ca7f23322
author John Stiles <johnstiles@google.com> 1656692561 -0400
committer SkCQ <skcq-be@skia-corp.google.com.iam.gserviceaccount.com> 1656793152 +0000

Add padding to properly align mixed-size uniforms.

The UniformManager would previously assert if it detected an alignment
error, but did not actually have any mechanism for automatically adding
padding between misaligned elements. If a user specifies a uniform
layout like `uniform float a; uniform float4 b;`, we now insert padding
between `a` and `b` so that `b` will be properly aligned. (This reuses
the logic that was originally used to trigger the alignment assertion.)

This CL fixes the bug and adds a test. The test is only active for
elements of matching size; mixed half- and full-precision elements
will need improved test logic.

Change-Id: I8c04eb6350fa73bdbcd1a08e1a45b17fee0d4194
Bug: skia:13478
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/555440
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: John Stiles <johnstiles@google.com>
Auto-Submit: John Stiles <johnstiles@google.com>