commit 4b1bd5d015bd4d5145d2cb33bfed155d0f7750f6
author Brian Salomon <bsalomon@google.com> Tue Apr 03 09:58:37 2018 -0400
committer Brian Salomon <bsalomon@google.com> Tue Apr 03 18:14:02 2018 +0000
tree 05392616e8dafb1f06fb86acf3d640d3e42c470f
parent 2f41171ed03927e05dceafacfde6449bab001472

Increase precision in GrSRGBEffect

Allows ApplyGammaTest to pass on Bifrost, which uses fp16 for mediump.

Change-Id: Icd04001939a2cb7e1789132ab035ca498c92112a
Reviewed-on: https://skia-review.googlesource.com/118162
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
(cherry picked from commit 08c39fcbcb68f5b0081ec69b4f5bd3c8dff23f9f)
Reviewed-on: https://skia-review.googlesource.com/118280
Reviewed-by: Hal Canary <halcanary@google.com>

src/gpu/effects/GrSRGBEffect.cpp

diff --git a/src/gpu/effects/GrSRGBEffect.cpp b/src/gpu/effects/GrSRGBEffect.cpp
index 7e823ea..6ca9759 100644
--- a/src/gpu/effects/GrSRGBEffect.cpp
+++ b/src/gpu/effects/GrSRGBEffect.cpp
@@ -47,7 +47,9 @@
             args.fInputColor = "half4(1)";
         }
 
-        fragBuilder->codeAppendf("half4 color = %s;", args.fInputColor);
+        // Mali Bifrost uses fp16 for mediump. Making the intermediate color variable highp causes
+        // calculations to be performed with sufficient precision.
+        fragBuilder->codeAppendf("float4 color = %s;", args.fInputColor);
         if (srgbe.alpha() == GrSRGBEffect::Alpha::kPremul) {
             fragBuilder->codeAppendf("half nonZeroAlpha = max(color.a, 0.00001);");
             fragBuilder->codeAppendf("color = half4(color.rgb / nonZeroAlpha, color.a);");