)]}' { "commit": "3f93b7265f558c414d0f33a7771be52b1fd1ce61", "tree": "9fa78b7d8729308416a7c7cadef3bc53b91d5a7e", "parents": [ "f21254fbe09cd03b95f6ab5943700901d8e94673" ], "author": { "name": "Mike Reed", "email": "reed@google.com", "time": "Sun Jun 18 10:49:36 2017 +0000" }, "committer": { "name": "Skia Commit-Bot", "email": "skia-commit-bot@chromium.org", "time": "Sun Jun 18 10:49:43 2017 +0000" }, "message": "Revert \"reduce SkDisplacementImageFilter size\"\n\nThis reverts commit ed68a92ca65762f0d0c4060668ceeb9c92506cf9.\n\nReason for revert: breaks layouttests (on BGRA?)\n\nOriginal change\u0027s description:\n\u003e reduce SkDisplacementImageFilter size\n\u003e \n\u003e saves ~8K on mac laptop\n\u003e \n\u003e - remove templates\n\u003e - check for 0 0r 0xFF in alpha\n\u003e \n\u003e Before: (using modified bench w/o caching)\n\u003e \n\u003e 23/23 MB\t2\t134µs\t151µs\t146µs\t156µs\t6%\t█▇▆▆▆▆▄▁▁▁\t8888\tdisplacement_full_large\n\u003e 23/23 MB\t2\t253µs\t254µs\t255µs\t260µs\t1%\t█▄▄▅▂▁▂▁▁▁\t8888\tdisplacement_alpha_large\n\u003e 24/24 MB\t1\t410µs\t410µs\t415µs\t445µs\t3%\t█▃▁▂▁▁▁▁▁▁\t8888\tdisplacement_zero_large\n\u003e 24/24 MB\t151\t840ns\t841ns\t853ns\t938ns\t4%\t█▁▁▁▁▁▁▂▁▁\t8888\tdisplacement_full_small\n\u003e 24/24 MB\t180\t832ns\t835ns\t836ns\t851ns\t1%\t█▂▁▂▂▁▂▂▂▂\t8888\tdisplacement_alpha_small\n\u003e 24/24 MB\t9\t60µs\t60.9µs\t69.9µs\t101µs\t19%\t█▄▄▄▁▁▁▁▁▁\t8888\tdisplacement_zero_small\n\u003e \n\u003e After:\n\u003e \n\u003e 23/23 MB\t3\t47.4µs\t48µs\t48.2µs\t51.4µs\t2%\t█▂▂▃▃▁▁▁▂▁\t8888\tdisplacement_full_large\n\u003e 23/23 MB\t2\t140µs\t141µs\t145µs\t166µs\t7%\t▂▁▁▁▁▁▁▁▇█\t8888\tdisplacement_alpha_large\n\u003e 24/24 MB\t2\t189µs\t196µs\t197µs\t225µs\t5%\t█▃▂▂▂▂▃▂▁▁\t8888\tdisplacement_zero_large\n\u003e 24/24 MB\t134\t588ns\t594ns\t597ns\t616ns\t1%\t▂▁▁█▂▆▂▂▃▄\t8888\tdisplacement_full_small\n\u003e 24/24 MB\t168\t590ns\t592ns\t592ns\t599ns\t0%\t▃▂▁▁▁▁▁█▂▂\t8888\tdisplacement_alpha_small\n\u003e 24/24 MB\t9\t8.39µs\t8.41µs\t8.42µs\t8.53µs\t0%\t█▄▃▂▁▁▃▂▁▂\t8888\tdisplacement_zero_small\n\u003e \n\u003e Bug: skia:\n\u003e Change-Id: Ia3b12dc8420b32b65633bb1cf76a15241e420eac\n\u003e Reviewed-on: https://skia-review.googlesource.com/20181\n\u003e Reviewed-by: Mike Klein \u003cmtklein@google.com\u003e\n\u003e Commit-Queue: Mike Reed \u003creed@google.com\u003e\n\nTBR\u003dmtklein@google.com,robertphillips@google.com,fmalita@chromium.org,reed@google.com\n\nChange-Id: I811c5f25a328c75527ce5caa0d9b8e123d535583\nNo-Presubmit: true\nNo-Tree-Checks: true\nNo-Try: true\nBug: skia:\nReviewed-on: https://skia-review.googlesource.com/20182\nReviewed-by: Mike Reed \u003creed@google.com\u003e\nCommit-Queue: Mike Reed \u003creed@google.com\u003e\n", "tree_diff": [ { "type": "modify", "old_id": "83f97b935381ba3f93ac0efbd993dd66387c990b", "old_mode": 33188, "old_path": "src/effects/SkDisplacementMapEffect.cpp", "new_id": "82c2b59acad324b455afd27bce422cd161be5a13", "new_mode": 33188, "new_path": "src/effects/SkDisplacementMapEffect.cpp" } ] }