tree 42fcd5d56a2a41ac91d6a2bd0e392736cca3dfc6
parent e4f87106d5eda75d95e1f8ca8bda742d0d9443ad
author Ben Wagner <bungeman@google.com> 1613793310 -0500
committer Skia Commit-Bot <skia-commit-bot@chromium.org> 1613835923 +0000

Disable -Wrange-loop-analysis.

This warning was originally a stand alone clang warning, not part of
'all' or 'extra', which had false positives. These false positives were
particularly accute when a container's iterators are proxy iterators.
Unfortunately the warning was moved into 'all' before being fixed.

After this became apparent, the warning was modified and split up, but
not before it was shipped in Clang 10 and XCode 11. It appears the fixed
version of the warning is in Clang 12 and XCode 12. Until the older
compilers are no longer supported, disable the warning.

This explicitly keeps the useful range-loop-construct warning which is
part of the range-loop-analysis. The range-loop-bind-reference part is
disabled.

Change-Id: I4023613bc14ac90989e699989b49582fbd4793d7
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/372816
Commit-Queue: Ben Wagner <bungeman@google.com>
Reviewed-by: Herb Derby <herb@google.com>