)]}'
{
  "commit": "1c577cd3ee331944b9061ee0eec147b211ee563c",
  "tree": "ca4e2ea83c7b2343844c4e60d5d7c03353178d30",
  "parents": [
    "2e09d18f78f5772d2d9506ff8024ca8542654358"
  ],
  "author": {
    "name": "mtklein",
    "email": "mtklein@chromium.org",
    "time": "Wed Jul 09 09:54:10 2014 -0700"
  },
  "committer": {
    "name": "Commit bot",
    "email": "commit-bot@chromium.org",
    "time": "Wed Jul 09 09:54:11 2014 -0700"
  },
  "message": "Always initialize SkDashPathEffect fields.\n\nSkDashPathEffect is flattened into a hash key as part of the old-and-busted\nSkPicture paint deduping code.  If all its fields aren\u0027t intialized, this hash\nwill be based on uninitialized data.  This means the hash won\u0027t be\ndeterministic, and worse, Valgrind and MSAN will make us feel bad.\n\nAn alternative to this is to have SkDashPath::CalcDashParameters always\nguarantee it writes something to all its output parameters, even when the dash\nintervals make no sense.  I like it being dumb and its users defensive, but\ncould go either way.\n\nBUG\u003d391001\nR\u003dreed@google.com, mtklein@google.com\n\nAuthor: mtklein@chromium.org\n\nReview URL: https://codereview.chromium.org/379813004\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "2838b1ff3e2aa4cce43c6bf5d984e303d05d7b41",
      "old_mode": 33188,
      "old_path": "src/effects/SkDashPathEffect.cpp",
      "new_id": "d91e7be977925b471199a4263737e20fb632deec",
      "new_mode": 33188,
      "new_path": "src/effects/SkDashPathEffect.cpp"
    }
  ]
}