)]}'
{
  "commit": "0e0b520fed3412648edb78fd46f4bd668dca2dea",
  "tree": "caa33b4cf064785f912b6bfcc193ec74342793d4",
  "parents": [
    "e727b91ec444203aa559f16e7f55d8fc9cc53c5a"
  ],
  "author": {
    "name": "K Lubick",
    "email": "kjlubick@google.com",
    "time": "Mon Apr 01 14:21:42 2024 -0400"
  },
  "committer": {
    "name": "Kevin Lubick",
    "email": "kjlubick@google.com",
    "time": "Mon Apr 01 19:42:44 2024 +0000"
  },
  "message": "Fix some c++20 warnings\n\nIn some of our benchmarks, we use volatile to try to make sure\nthe compiler doesn\u0027t optimize away certain operations. If there is a better way to do that, I\u0027m open to that.\n\nImplicit capturing of this in lambdas has been deprecated due to the\npotentially confusing behavior. [1] Changing [\u003d] -\u003e [\u003d, this] won\u0027t\nwork due to the latter being a c++20 extension. However, for many\nuses, we can improve the style/readability of the code anyway [2]\nby making the captures explicit.\n\nFinally, there was a warning about non-const operator\u003d\u003d being ambiguous,\nso I fixed those I could find with grep.\n\n[1] https://www.open-std.org/jtc1/sc22/wg21/docs/papers/2018/p0806r2.html\n[2] https://google.github.io/styleguide/cppguide.html#Lambda_expressions  \"Prefer explicit captures when the lambda will escape the current scope.\"\n\nBug: b/311238827\nChange-Id: I1725adaa2c258e0fdee2fe398647c15d2cbc9966\nReviewed-on: https://skia-review.googlesource.com/c/skia/+/833811\nReviewed-by: John Stiles \u003cjohnstiles@google.com\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "66e2bbcfd3c71f6c2679d1bfcc42e1b35580161b",
      "old_mode": 33188,
      "old_path": "bench/ColorPrivBench.cpp",
      "new_id": "a00355b76f266a692d1ef12bcf11c5fc16e5e0ce",
      "new_mode": 33188,
      "new_path": "bench/ColorPrivBench.cpp"
    },
    {
      "type": "modify",
      "old_id": "20713b97dd6af495e495a6e4cbf62241e177521c",
      "old_mode": 33188,
      "old_path": "bench/ControlBench.cpp",
      "new_id": "0b7683a64326e9141a36cd038ff801c1a03561b5",
      "new_mode": 33188,
      "new_path": "bench/ControlBench.cpp"
    },
    {
      "type": "modify",
      "old_id": "bd7eaa65975024041c348e4622a9765063a92b86",
      "old_mode": 33188,
      "old_path": "bench/GeometryBench.cpp",
      "new_id": "23c73ab346e8ea0ac8ba28f7b1f0f2844a2b78d0",
      "new_mode": 33188,
      "new_path": "bench/GeometryBench.cpp"
    },
    {
      "type": "modify",
      "old_id": "48c730defc148b66e2c5b16af0f9c8bde588a911",
      "old_mode": 33188,
      "old_path": "bench/MathBench.cpp",
      "new_id": "d84c938a834860aff9790b0ba167ed5053abdc64",
      "new_mode": 33188,
      "new_path": "bench/MathBench.cpp"
    },
    {
      "type": "modify",
      "old_id": "1e5a4c264e2176698ebc237ed8219261f08aa1a7",
      "old_mode": 33188,
      "old_path": "bench/MatrixBench.cpp",
      "new_id": "c3e494509f8787c030fe9c501ba323bb791a3bdd",
      "new_mode": 33188,
      "new_path": "bench/MatrixBench.cpp"
    },
    {
      "type": "delete",
      "old_id": "021b911ca7d28a364d69348f10f48d4a8ebef9ef",
      "old_mode": 33188,
      "old_path": "bench/ScalarBench.cpp",
      "new_id": "0000000000000000000000000000000000000000",
      "new_mode": 0,
      "new_path": "/dev/null"
    },
    {
      "type": "modify",
      "old_id": "9b477876cda8eeda966d0777ea53ab6de15108ea",
      "old_mode": 33188,
      "old_path": "fuzz/FuzzDDLThreading.cpp",
      "new_id": "01794873a9a9a94ed6abab3c2d01f73c9963257d",
      "new_mode": 33188,
      "new_path": "fuzz/FuzzDDLThreading.cpp"
    },
    {
      "type": "modify",
      "old_id": "7b26afa673ab14688769ff828b435154b75c96db",
      "old_mode": 33188,
      "old_path": "gn/bench.gni",
      "new_id": "64e928c3a09d2478c2647715e168ff3c84090043",
      "new_mode": 33188,
      "new_path": "gn/bench.gni"
    },
    {
      "type": "modify",
      "old_id": "6ed7659716e1697e35ae7d82eb4b18346bb52d31",
      "old_mode": 33188,
      "old_path": "src/core/SkPath.cpp",
      "new_id": "ea0a98fe05847af5b7ab35ae8eb517edd8d6aaae",
      "new_mode": 33188,
      "new_path": "src/core/SkPath.cpp"
    },
    {
      "type": "modify",
      "old_id": "672756ef36811cb80694e3b3062f3a52bc5c5d9d",
      "old_mode": 33188,
      "old_path": "src/core/SkTaskGroup.cpp",
      "new_id": "cd5c50fe255f4219e7a3eaf91b35175ab4923f79",
      "new_mode": 33188,
      "new_path": "src/core/SkTaskGroup.cpp"
    },
    {
      "type": "modify",
      "old_id": "ddf44489d2f1e656728cfc4b4775e9909aac1957",
      "old_mode": 33188,
      "old_path": "src/gpu/ganesh/glsl/GrGLSLShaderBuilder.cpp",
      "new_id": "8bdd2775b79a6f9702d71f1b040a9527e14a3d75",
      "new_mode": 33188,
      "new_path": "src/gpu/ganesh/glsl/GrGLSLShaderBuilder.cpp"
    },
    {
      "type": "modify",
      "old_id": "579434ba8e3a199d8a937d46c2fc7023bf2dc989",
      "old_mode": 33188,
      "old_path": "src/pdf/SkPDFTypes.h",
      "new_id": "cfa9986b845c0679ad6ded59e5b6ab467e70fadd",
      "new_mode": 33188,
      "new_path": "src/pdf/SkPDFTypes.h"
    },
    {
      "type": "modify",
      "old_id": "d752f506de92df6e7ef99f9b4ae8193da9f72293",
      "old_mode": 33188,
      "old_path": "src/ports/SkFontMgr_fuchsia.cpp",
      "new_id": "e37a2777816fea8109a54a8302ac3744e55ad546",
      "new_mode": 33188,
      "new_path": "src/ports/SkFontMgr_fuchsia.cpp"
    },
    {
      "type": "modify",
      "old_id": "06143ef6dc9c6ab4566e738dd6660c95a24d19f4",
      "old_mode": 33188,
      "old_path": "tests/TArrayTest.cpp",
      "new_id": "ec4be362594e77923fe57baa905819ceecd1ebe7",
      "new_mode": 33188,
      "new_path": "tests/TArrayTest.cpp"
    },
    {
      "type": "modify",
      "old_id": "fd629e8d1687779b51a111532e326aa414d12c46",
      "old_mode": 33188,
      "old_path": "tools/viewer/Viewer.cpp",
      "new_id": "f60edb0f68474969bdc7bd1ae6076ee73941c07e",
      "new_mode": 33188,
      "new_path": "tools/viewer/Viewer.cpp"
    }
  ]
}