skia /
skia /
04494113156329edb2babe2be3f210df1218bfe0 [Fontations] Fix bounding box calculation under transforms
BoundsPainter did not track transforms correctly, which led to bounding
boxes being calculated incorrectly when nested transforms were popped
through calls to pop_transform() on BoundsPainter. Turns out, just
keeping one invertable level is not enough. Add a transform stack and
pop previous transforms correctly.
Tested locally with PlakatoColor. As this font is not open-source, I
will add separate testing to the COLRv1 test font for this case and
submit a separate test later.
Bug: skia:376292019
Cq-Include-Trybots: luci.skia.skia.primary:Build-Debian10-Clang-x86_64-Debug-Fontations,Build-Mac-Clang-x86_64-Debug-Fontations,Test-Debian10-Clang-GCE-CPU-AVX2-x86_64-Debug-All-NativeFonts_Fontations,Test-Mac12-Clang-MacBookPro16.2-CPU-AppleIntel-x86_64-Debug-All-NativeFonts_Fontations
Change-Id: If48d2b93a46d5ef2367b8ffb4d67598fc48a0b36
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/914716
Reviewed-by: Dominik Röttsches <drott@google.com>
Commit-Queue: Dominik Röttsches <drott@google.com>
Reviewed-by: Ben Wagner <bungeman@google.com>
2 files changed
