)]}'
{
  "commit": "ded032c4c989d3ab6fe74db351cdba858aca04ea",
  "tree": "4dea10542b4f6a9aa608abb9be41a748be823bf5",
  "parents": [
    "85ff9570a51a143a949f43ff357ffe40c3ede5c0"
  ],
  "author": {
    "name": "Brian Osman",
    "email": "brianosman@google.com",
    "time": "Mon Jan 07 19:14:13 2019 +0000"
  },
  "committer": {
    "name": "Skia Commit-Bot",
    "email": "skia-commit-bot@chromium.org",
    "time": "Mon Jan 07 19:14:26 2019 +0000"
  },
  "message": "Revert \"Support combining per-vertex coverage with color in default GP vertex shader\"\n\nThis reverts commit 8e13f69262eeb01e926df4eb79e89615cc741be5.\n\nReason for revert: Layout tests still failing.\n\nOriginal change\u0027s description:\n\u003e Support combining per-vertex coverage with color in default GP vertex shader\n\u003e \n\u003e Leverage this in ops that use tessellation with per-vertex coverage, to\n\u003e move the (color * coverage) work into the vertex shader.\n\u003e \n\u003e For the tessellating path renderer, color is always uniform, but we were\n\u003e sending it per-vertex. Added support to the default GP for routing the\n\u003e uniform color to the vertex shader (when there is per-vertex coverage and\n\u003e coverage can be folded into alpha). The end result is that we do less work\n\u003e on the CPU, and send less data (for incompatible blend modes) or the same\n\u003e amount (for compatible blend modes).\n\u003e \n\u003e Finally, because color is never sent through a vertex attribute, this\n\u003e solves wide color (and avoids the vertex bloat that would have happened\n\u003e when using half-floats). For the linearizing convex path renderer, do the\n\u003e usual fix for wide color.\n\u003e \n\u003e PS6 is the \"clean\" version of this CL, later versions are guarded to\n\u003e rebaseline layout tests.\n\u003e \n\u003e Bug: skia:\n\u003e Change-Id: I7fa87219177d36db800463d4492b78f2cb14a1c3\n\u003e Reviewed-on: https://skia-review.googlesource.com/c/179996\n\u003e Reviewed-by: Brian Salomon \u003cbsalomon@google.com\u003e\n\u003e Reviewed-by: Jim Van Verth \u003cjvanverth@google.com\u003e\n\u003e Commit-Queue: Brian Osman \u003cbrianosman@google.com\u003e\n\nTBR\u003djvanverth@google.com,bsalomon@google.com,senorblanco@chromium.org,brianosman@google.com,senorblanco@google.com\n\nChange-Id: Idf2b4c4b4d6bb6683bf6293d9e9a5ba097f38289\nNo-Presubmit: true\nNo-Tree-Checks: true\nNo-Try: true\nBug: skia:\nReviewed-on: https://skia-review.googlesource.com/c/181762\nReviewed-by: Brian Osman \u003cbrianosman@google.com\u003e\nCommit-Queue: Brian Osman \u003cbrianosman@google.com\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "3a81a2571a8632f2241c11b585065cf45a3b2c3e",
      "old_mode": 33188,
      "old_path": "src/gpu/GrDefaultGeoProcFactory.cpp",
      "new_id": "172b6d83f55b4e166c720a9ca3252782513bc83b",
      "new_mode": 33188,
      "new_path": "src/gpu/GrDefaultGeoProcFactory.cpp"
    },
    {
      "type": "modify",
      "old_id": "96363f05fe5119ad29e60ef0d9b9466d6e59d3e4",
      "old_mode": 33188,
      "old_path": "src/gpu/GrDefaultGeoProcFactory.h",
      "new_id": "af336686eea41077500d22096fec088ba043701d",
      "new_mode": 33188,
      "new_path": "src/gpu/GrDefaultGeoProcFactory.h"
    },
    {
      "type": "modify",
      "old_id": "b75370778c715d7692af833bfac7d941f7cb15b1",
      "old_mode": 33188,
      "old_path": "src/gpu/GrTessellator.cpp",
      "new_id": "19b859e98117d15cdf202a89fca8a4c0e164d44c",
      "new_mode": 33188,
      "new_path": "src/gpu/GrTessellator.cpp"
    },
    {
      "type": "modify",
      "old_id": "324a72c2f3f55e694f0d5ffbafe29a3b637bfdd9",
      "old_mode": 33188,
      "old_path": "src/gpu/GrTessellator.h",
      "new_id": "4f82ea8b8c32da9ee96b01bf25d3d5fab2b87ec4",
      "new_mode": 33188,
      "new_path": "src/gpu/GrTessellator.h"
    },
    {
      "type": "modify",
      "old_id": "b007245b43089e4361ddd46df1b419af79f99a97",
      "old_mode": 33188,
      "old_path": "src/gpu/ops/GrAALinearizingConvexPathRenderer.cpp",
      "new_id": "52785eb1f7fd8f85deff11cb468dc4cee0551168",
      "new_mode": 33188,
      "new_path": "src/gpu/ops/GrAALinearizingConvexPathRenderer.cpp"
    },
    {
      "type": "modify",
      "old_id": "28ad0834b5606b0be179cff585d676fc7e0309d3",
      "old_mode": 33188,
      "old_path": "src/gpu/ops/GrTessellatingPathRenderer.cpp",
      "new_id": "a59c161479005bb97f0256cfc939b43d287e0255",
      "new_mode": 33188,
      "new_path": "src/gpu/ops/GrTessellatingPathRenderer.cpp"
    }
  ]
}
