)]}'
{
  "commit": "b7a1b5189d3cb259068c7bbf3f10bda7b67141f2",
  "tree": "79c9f424702e588d151921f0ee10ddf8d3c6a876",
  "parents": [
    "454e5fb7457dacc4c508187ed879ceb6c9d0302d"
  ],
  "author": {
    "name": "Nigel Tao",
    "email": "nigeltao@google.com",
    "time": "Sun Feb 10 12:19:50 2019 +1100"
  },
  "committer": {
    "name": "Skia Commit-Bot",
    "email": "skia-commit-bot@chromium.org",
    "time": "Tue Feb 12 03:48:10 2019 +0000"
  },
  "message": "SkWuffsCodec: zero dst buffer before decodeFrame\n\nhttps://skia-review.googlesource.com/c/189866 \"SkWuffsCodec: Initialize\nmemory when incomplete\" made some buffer zero\u0027ing conditional on a\nframe\u0027s dirty rectangle, which required moving the this-\u003edecodeFrame\ncall earlier in onIncrementalDecode, since we can\u0027t know the dirty\nrectangle until after decodeFrame is called.\n\nHowever, moving that earlier meant that it was now earlier than the\n\"sk_bzero(pixels.ptr + etc, etc)\" call that zero-initialized the\ndestination buffer that decodeFrame writes to. The actual pixel indexes\nthat decodeFrame decodes are now overwritten by zeroes.\n\nThat prior commit fixed the fuzzer-discovered bug, in that it no longer\nswizzles from uninitialized memory. Unfortunately, it\u0027s now often\nswizzling from all-zeroed memory, so that the decoding is incorrect.\n\nThis commit moves the zero-ing to onStartIncrementalDecode, even\nearlier. The \"dm --match Gif\" tests are happy again.\n\nBug: skia:8235\nChange-Id: Iae993b7d9f45e1b375ed99f6cc86536091a92eba\nReviewed-on: https://skia-review.googlesource.com/c/190941\nReviewed-by: Leon Scroggins \u003cscroggo@google.com\u003e\nCommit-Queue: Leon Scroggins \u003cscroggo@google.com\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "04da11cd1646762058f3cfa080dec7ba53c7307c",
      "old_mode": 33188,
      "old_path": "src/codec/SkWuffsCodec.cpp",
      "new_id": "8384c1cdb818afa45f01fb7aca91f55463c95d73",
      "new_mode": 33188,
      "new_path": "src/codec/SkWuffsCodec.cpp"
    }
  ]
}