| commit | 723a877d0c59fad07659ccd67ea6b85dbedb9c84 | [log] [tgz] |
|---|---|---|
| author | Ben Wagner <bungeman@google.com> | Fri Aug 16 11:36:58 2019 -0400 |
| committer | Skia Commit-Bot <skia-commit-bot@chromium.org> | Tue Aug 20 20:31:36 2019 +0000 |
| tree | ea916a96a0f9e0d54b6ccca722345d65f81c2da3 | |
| parent | 6f1ff9fca1b1800525089b5161b3dd52a8df9886 [diff] |
Make SkFunctionWrapper a better wrapper. SkFunctionWrapper was made to be a simple abstraction over existing resource release functions which generally follow a specific pattern of returning void and taking a pointer to the underlying type. However, this has been observed to be an unnecessary limit. This makes it more generic while also making the call sites a little less brittle. This change also uncovered an issue in msvc v19.20 to v19.22, see https://developercommunity.visualstudio.com/content/problem/698192/in-templateusing-decltype-is-void.html To work around this, several otherwise redundant '&' are used. There was an attempt to take references to functions instead of pointers to functions which greatly simplifies the intermediate wrappers. However, that uncovered another issue in msvc, see https://developercommunity.visualstudio.com/content/problem/699878/function-to-pointer.html Change-Id: I54ab945ed9d9cfd0204d4d6650c2fde47cc9e175 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/235105 Commit-Queue: Ben Wagner <bungeman@google.com> Reviewed-by: Herb Derby <herb@google.com>