commit 0a1923e50752073fd31ad667935c9e37681917e8
author Chris Dalton <csmartdalton@google.com> Fri Jan 10 17:45:44 2020 -0700
committer Skia Commit-Bot <skia-commit-bot@chromium.org> Sat Jan 11 06:04:56 2020 +0000
tree 9d3ba73b045483f6dda77351c387b77b856422f3
parent a3a704afa3a344dc6fdb6fcb082bd7686ed0a6dc

Disable QCOM_tiled_rendering while we wait for test devices

There are devices that advertise this extension but don't actually
provide the GL entrypoints. This is causing live crashes.

Bug: flutter:47164
Bug: flutter:47804
Change-Id: Idded47e8dbd4462463ad91a62b06b0df3245f0c1
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/263809
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Chris Dalton <csmartdalton@google.com>

src/gpu/gl/GrGLCaps.cpp

diff --git a/src/gpu/gl/GrGLCaps.cpp b/src/gpu/gl/GrGLCaps.cpp
index 4462e72..782c203 100644
--- a/src/gpu/gl/GrGLCaps.cpp
+++ b/src/gpu/gl/GrGLCaps.cpp
@@ -697,9 +697,11 @@
         fSamplerObjectSupport = version >= GR_GL_VER(2,0);
     }
 
-    if (GR_IS_GR_GL_ES(standard)) {
-        fTiledRenderingSupport = ctxInfo.hasExtension("GL_QCOM_tiled_rendering");
-    }
+    // https://github.com/flutter/flutter/issues/47164
+    // https://github.com/flutter/flutter/issues/47804
+    // if (GR_IS_GR_GL_ES(standard)) {
+    //     fTiledRenderingSupport = ctxInfo.hasExtension("GL_QCOM_tiled_rendering");
+    // }
 
     FormatWorkarounds formatWorkarounds;
 

src/gpu/gl/GrGLInterfaceAutogen.cpp

diff --git a/src/gpu/gl/GrGLInterfaceAutogen.cpp b/src/gpu/gl/GrGLInterfaceAutogen.cpp
index 839daa5..572dc14 100644
--- a/src/gpu/gl/GrGLInterfaceAutogen.cpp
+++ b/src/gpu/gl/GrGLInterfaceAutogen.cpp
@@ -351,10 +351,7 @@
 
     if ((GR_IS_GR_GL_ES(fStandard) && (
           fExtensions.has("GL_QCOM_tiled_rendering")))) {
-        if (!fFunctions.fEndTiling ||
-            !fFunctions.fStartTiling) {
-            RETURN_FALSE_INTERFACE;
-        }
+        // all functions were marked optional or test_only
     }
 
     if ((GR_IS_GR_GL(fStandard) && (

tools/gpu/gl/interface/interface.json5

diff --git a/tools/gpu/gl/interface/interface.json5 b/tools/gpu/gl/interface/interface.json5
index 12c68d7..a940720 100644
--- a/tools/gpu/gl/interface/interface.json5
+++ b/tools/gpu/gl/interface/interface.json5
@@ -300,6 +300,11 @@
 
     "functions": [
       "StartTiling", "EndTiling",
+    ],
+    // https://github.com/flutter/flutter/issues/47164
+    // https://github.com/flutter/flutter/issues/47804
+    "optional": [
+      "StartTiling", "EndTiling",
     ]
   },