)]}' { "log": [ { "commit": "02738a86e5fd44f0a2c91882a9fba727e803530a", "tree": "d7c626b6e88fea830c87026859d32dddb02571a4", "parents": [ "9c6ee015c352e0172d1707f260e02d3d19739cd4" ], "author": { "name": "Hal Canary", "email": "halcanary@google.com", "time": "Mon Jan 21 18:51:32 2019 +0000" }, "committer": { "name": "Skia Commit-Bot", "email": "skia-commit-bot@chromium.org", "time": "Mon Jan 21 18:51:39 2019 +0000" }, "message": "Revert \"hide hinting and flag enums with PAINT_FLAGS\"\n\nThis reverts commit 5d052dac3ac19e6ddff8b004541310241a4e70e5.\n\nReason for revert: BREAKS CHROMIUM ROLL.\n\nhttps://cs.chromium.org/chromium/src/third_party/blink/renderer/platform/fonts/win/font_platform_data_win.cc?l\u003d49\n| FAILED: obj/third_party/blink/renderer/platform/platform/font_platform_data_win.obj\n| ../../third_party/blink/renderer/platform/fonts/win/font_platform_data_win.cc(49,29):\n| error: no member named \u0027kLCDRenderText_Flag\u0027 in \u0027SkPaint\u0027\n| if (text_flags \u0026 SkPaint::kLCDRenderText_Flag) {\n| ~~~~~~~~~^\n| ../../third_party/blink/renderer/platform/fonts/win/font_platform_data_win.cc(51,36):\n| error: no member named \u0027kAntiAlias_Flag\u0027 in \u0027SkPaint\u0027\n| } else if (text_flags \u0026 SkPaint::kAntiAlias_Flag) {\n| ~~~~~~~~~^\n| ../../third_party/blink/renderer/platform/fonts/win/font_platform_data_win.cc(56,52):\n| error: no member named \u0027kSubpixelText_Flag\u0027 in \u0027SkPaint\u0027\n| font-\u003esetSubpixel(SkToBool(text_flags \u0026 SkPaint::kSubpixelText_Flag));\n| ~~~~~~~~~^\n| ../../third_party/blink/renderer/platform/fonts/win/font_platform_data_win.cc(64,29):\n| error: no member named \u0027kAntiAlias_Flag\u0027 in \u0027SkPaint\u0027\n| if (text_flags \u0026 SkPaint::kAntiAlias_Flag)\n| ~~~~~~~~~^\n| ../../third_party/blink/renderer/platform/fonts/win/font_platform_data_win.cc(85,27):\n| error: no member named \u0027kAntiAlias_Flag\u0027 in \u0027SkPaint\u0027\n| ? SkPaint::kAntiAlias_Flag\n| ~~~~~~~~~^\n| ../../third_party/blink/renderer/platform/fonts/win/font_platform_data_win.cc(91,35):\n| error: no member named \u0027kLCDRenderText_Flag\u0027 in \u0027SkPaint\u0027\n| ? SkPaint::kLCDRenderText_Flag\n| ~~~~~~~~~^\n| ../../third_party/blink/renderer/platform/fonts/win/font_platform_data_win.cc(93,27):\n| error: no member named \u0027kAntiAlias_Flag\u0027 in \u0027SkPaint\u0027\n| text_flags \u003d SkPaint::kAntiAlias_Flag | lcd_flag;\n| ~~~~~~~~~^\n| ../../third_party/blink/renderer/platform/fonts/win/font_platform_data_win.cc(101,28):\n| error: no member named \u0027kAntiAlias_Flag\u0027 in \u0027SkPaint\u0027\n| text_flags |\u003d SkPaint::kAntiAlias_Flag;\n| ~~~~~~~~~^\n| 8 errors generated.\n\nOriginal change\u0027s description:\n\u003e hide hinting and flag enums with PAINT_FLAGS\n\u003e \n\u003e A preflight for https://skia-review.googlesource.com/c/skia/+/185460\n\u003e \n\u003e Bug: skia:2664\n\u003e Change-Id: I83f7f9cd500e8507b559462835477ba8ae7c11ab\n\u003e Reviewed-on: https://skia-review.googlesource.com/c/185540\n\u003e Reviewed-by: Mike Reed \u003creed@google.com\u003e\n\u003e Commit-Queue: Mike Reed \u003creed@google.com\u003e\n\u003e Auto-Submit: Mike Reed \u003creed@google.com\u003e\n\nTBR\u003dreed@google.com\n\nChange-Id: I4d1581a7e29267ad459ed31d4885b823fa00066f\nNo-Presubmit: true\nNo-Tree-Checks: true\nNo-Try: true\nBug: skia:2664\nReviewed-on: https://skia-review.googlesource.com/c/185680\nReviewed-by: Hal Canary \u003chalcanary@google.com\u003e\nCommit-Queue: Hal Canary \u003chalcanary@google.com\u003e\n" }, { "commit": "9c6ee015c352e0172d1707f260e02d3d19739cd4", "tree": "898314af4790189fff8abd6a40bbec855b58ec9c", "parents": [ "226ba98668f7016c18e1833f435dfc795b30fb38" ], "author": { "name": "Brian Osman", "email": "brianosman@google.com", "time": "Wed Jan 16 13:13:36 2019 -0500" }, "committer": { "name": "Skia Commit-Bot", "email": "skia-commit-bot@chromium.org", "time": "Mon Jan 21 18:12:28 2019 +0000" }, "message": "SkColorSpace API cleanup\n\nPreviously:\n- Gamut could be a 4x4 matrix (overspecified), or an enum.\n- Transfer function could be a struct with 7 floats, or one of two\n different enums.\n- We had 5 of the 6 possible factories covering those [3 x 2] options.\n\nRecently we added a single new factory that takes the skcms 7-float\nstruct, and the skcms 3x3 matrix. This is the exact, minimal set of\ninformation needed to specify an SkColorSpace.\n\nMajor clients have been moved to that factory, so the other five are\nbeing removed. The enums are also being removed, as they are no longer\npart of the API. All transfer functions and gamuts covered by the old\nenums are available as constexpr values (of the skcms types) in the\nheader (SkNamedTransferFn and SkNamedGamut).\n\nBug: skia:\nChange-Id: I1fbbacec6997b966dd92000ab67513e7f1a9d023\nReviewed-on: https://skia-review.googlesource.com/c/184067\nReviewed-by: Brian Osman \u003cbrianosman@google.com\u003e\nReviewed-by: Mike Reed \u003creed@google.com\u003e\nReviewed-by: Mike Klein \u003cmtklein@google.com\u003e\nCommit-Queue: Brian Osman \u003cbrianosman@google.com\u003e\n" }, { "commit": "226ba98668f7016c18e1833f435dfc795b30fb38", "tree": "b223a8ff24274cdd40c3df70a271ab2653486119", "parents": [ "fa01b214d5e6faf97b7c69ba4d570bc453f325bf" ], "author": { "name": "Florin Malita", "email": "fmalita@chromium.org", "time": "Mon Jan 21 11:55:51 2019 -0500" }, "committer": { "name": "Skia Commit-Bot", "email": "skia-commit-bot@chromium.org", "time": "Mon Jan 21 17:29:33 2019 +0000" }, "message": "[skshaper] Export \"primitive\" sources in public.bzl\n\nThe harfbuzz backend is not usable in G3 at this point (missing\nSkLoadICU header). Making the primitive backend available to unblock\nSkottie progress.\n\nTBR\u003d\nBug: skia:8696\nChange-Id: I5aa1003f33926450f6c7512736cd71f9e1c80297\nReviewed-on: https://skia-review.googlesource.com/c/185600\nReviewed-by: Florin Malita \u003cfmalita@chromium.org\u003e\nCommit-Queue: Florin Malita \u003cfmalita@chromium.org\u003e\n" }, { "commit": "fa01b214d5e6faf97b7c69ba4d570bc453f325bf", "tree": "410c0b8915f79920d018c533d99719a1c52bbcea", "parents": [ "5d052dac3ac19e6ddff8b004541310241a4e70e5" ], "author": { "name": "skia-autoroll", "email": "skia-autoroll@skia-public.iam.gserviceaccount.com", "time": "Mon Jan 21 16:35:42 2019 +0000" }, "committer": { "name": "Skia Commit-Bot", "email": "skia-commit-bot@chromium.org", "time": "Mon Jan 21 17:23:44 2019 +0000" }, "message": "Roll third_party/externals/angle2 7403dd2cd376..bf433727853d (1 commits)\n\nhttps://chromium.googlesource.com/angle/angle.git/+log/7403dd2cd376..bf433727853d\n\n\ngit log 7403dd2cd376..bf433727853d --date\u003dshort --no-merges --format\u003d\u0027%ad %ae %s\u0027\n2019-01-21 jmadill@chromium.org Use binary merge strategy for code generator hashes.\n\n\nCreated with:\n gclient setdep -r third_party/externals/angle2@bf433727853d\n\nThe AutoRoll server is located here: https://autoroll.skia.org/r/angle-skia-autoroll\n\nDocumentation for the AutoRoller is here:\nhttps://skia.googlesource.com/buildbot/+/master/autoroll/README.md\n\nIf the roll is causing failures, please contact the current sheriff, who should\nbe CC\u0027d on the roll, and stop the roller if necessary.\n\nCQ_INCLUDE_TRYBOTS\u003dskia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE\nTBR\u003ddjsollen@google.com\n\nChange-Id: I290bb3004133fc6d3c932f6c1fadec8dc08f30bf\nReviewed-on: https://skia-review.googlesource.com/c/185562\nReviewed-by: skia-autoroll \u003cskia-autoroll@skia-public.iam.gserviceaccount.com\u003e\nCommit-Queue: skia-autoroll \u003cskia-autoroll@skia-public.iam.gserviceaccount.com\u003e\n" } ] }